* Feat: Handle "non-ASCII" account names better
Refactor the `pasteFilter` on the import -> account name EditControl to encode non-ASCII characters in a more URL-friendly manner than it was previously.
This change eliminates the need to use `www.urlencoder.org` so I've removed that warning and the button.
Tested OK with: 쁘레따뽀르떼#4360
* adjust position of missing discriminator warning
* add help message
The repeat stat was looking for a SkillType check on the minion skill but this is not correct. This change might make spell echo repeats affect some spell unintentionally but it's too hard to tell
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Adds spec for a number of files to do with skills and their corresponding animation files
This will now allow us to link up projectile speed values to their respective skills
--- New to Path of Building ---
* Add support for average Lightning Tendrils DPS (LocalIdentity)
* Show DPS comparison for Flask slots when hovering over Unique item list (Blitz54)
* Add Undo support to Tattoo/Runegraft overrides (Blitz54)
* Add total minimum weight parameter to Timeless Jewel finder (tserdar)
* Add Beastcrafts to Item crafter (brendan-corrigan)
* Add support for Defiance of Destiny Gain before enemy hit (Regisle)
* Add support for duration of Ailments Retaliation mastery (LocalIdentity)
* Add support for Ancestral Commander Ancestral Spirit Minion buffs (LocalIdentity)
* Add support for Chieftain's Ramako, Sun's Light notable (Ruthless version) (kisiex)
--- Fixed Crashes ---
* Fix crash when using "Add modifier" button on Tinctures (brendan-corrigan)
--- User Interface ---
* Add text after red mods to show that PoB does not currently handle them (LocalIdentity)
* Display distance in Units in graphic for AoE breakdown (Blitz54)
* Tooltip text "tattoo" or "runegraft" based on node type (Blitz54)
--- Fixed Calculations ---
* Use harmonic mean for dual wield attack speed calc instead of average (Tntmister)
* Fix tincture quality effect multiplier rounding issue (NL908)
* Fix rounding of scaled mods being incorrect in some cases (Wires77)
* Fix Temporal Chains double counting towards Brand Ticks (LocalIdentity)
* Fix Poison Conc of Bouncing not counting Chains towards DPS (LocalIdentity)
* Fix Glacial Hammer of Shattering missing crit chance every 3rd use (LocalIdentity)
* Fix Absolution/Dominating Blow of Inspiring FullDPS when using config (LocalIdentity)
--- Fixed Behaviours ---
* Fix Mine Aura effect scaling Curses used with High-Impact Mine (LocalIdentity)
* Fix Ancestral Bond disabling Generals Cry damage (LocalIdentity)
* Fix Hand of Phrecia disabling Mine Auras (LocalIdentity)
* Fix Light of Meaning double counting starting nodes on Ascendant (LocalIdentity)
* Fix Kaladra's Touch not copying influence from other ring (LocalIdentity)
* Fix Howlcrack causing inf DPS with Generals Cry (Paliak)
* Fix issue where Rage Support was affecting Herald of Purity (Wires77)
* Fix Volatility applying to Minion Spell skills (LocalIdentity)
* Fix Influence not appearing correctly in PoB Trader (t1nky)
* Fix enemy Ailment Immunity not working with Rune of Treachery (LocalIdentity)
* Fix Shepherd of Souls applying twice with 2 Yaomac's Accord equipped (LocalIdentity)
* Fix node tooltip when using Untuitive Leap or Impossible Escape (Kojoley)
* Fix Ancestral Vision not working correctly with The Arkhon's Tools (LocalIdentity)
* Fix Ascendant/Gladiator Block Chance when using Necromantic Aegis (LocalIdentity)
--- Accuracy Improvements ---
* Fix Betrayal's Sting and Unique Talisman's missing catalyst scaling (LocalIdentity)
* Fix Devouring Diadem in unique list using suffix veiled mods (LocalIdentity)
* Add Catalyst tags to Whispers of Infinity (linusalpsten)
* Update Cinderswallow and support new mods (LocalIdentity)
--- Fixed Bugs ---
* Fix importing characters with names that contain foreign letters (poyushih)
The node should not be granting the 50% block chance to the player if you are using Necromantic Aegis with it
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
The option to show only 1x the players hit DPS was not working for the alternate versions of the skill cause we were looking for a exact match on the name
Also realised that the config option was not even showing up for Dominating Blow of inspiring so fixed that too
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
We were not taking into account the ailment avoidance from Ancestral Vision when determining if the Skitterbots effects should be applied to the player
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Adds support for all the minions granted by the ascendancy and also the 5 legacy skills granted by Tattoo's that I believe still exist in standard and may come back in the future at some point
Adds support for tracking the number of each Tattoo type to properly scale the buff effects too
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
* Add support for average Lightning Tendrils DPS
Lightning Tendrils has a mechanic where it critically strikes every 3rd / 5th use but we were did not have a averaged calc for this
There is now a new skill part for the averaged DPS
I also applied DPS multipliers to the other 2 skill parts to show accurate DPS for just those parts when they hit as people may use the stronger pulse one to see DPS for Ignite
* Fix formula for average damage on Eccentricity
Averaging the crit chance and damage was not correct to get an accurate DPS value
---------
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Poisonous Concoction of Bouncing gains DPS from extra chains as the projectiles keep chaining to the same target
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
* Add text after red mods to show that PoB does not currently handle them
PoB does not calculate mods that have red text on them but many users do not know this. Adding this reminder text after all the lines should make it more obvious
* Fix first load crash
* Fix check for empty line
* Typo
* FIX: fixes toggle requiring reload, minor optimalizations (#8928)
The TooltipClass:CheckForUpdate had to be updated so that
the tooltip updates correctly after changing the option.
I kinda obsessed over optimizing this. Removed the secondary
loop as the first one without the break statement will
update all the records. Though this has the cost of doing
more comparisons which could end up being more expensive if
strings end up being compared often. Looking through current
calls to this function it seems like it's all just addresses
and booleans.
---------
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Co-authored-by: Paliak <91493239+Paliak@users.noreply.github.com>
Hovering over an unallocated node in radius of Impossible Escape or
Intuitive Leap currently shows difference for taking a path from the
class start which it doesn't require and won't take on click.
This is confusing and not helpful because highlight for the pathing
is being suppressed already.
The keystone effects were applied in mod parser so if you had more than 1 copy of the mod in your build it would apply multiple times
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Enemy ailment immunity or chance to avoid ailments was not factored into the sources of guaranteed ailments or chance ailments like ignite
Using Purity of Elements with the Runegraft now correctly disables all sources of elemental ailments on enemies
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
output.Duration is already modified by debuffDurationMult in the duration block above so it doesn't need to be applied here again
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
* Add support for Defiance of Destiny Gain before enemy hit
* update config and comment wording
* update config option label
* fix merge issues
* fix more merge issues
---------
Co-authored-by: LocalIdentity <31035929+LocalIdentity@users.noreply.github.com>
* FIX(mirage): fix cap GC cooldown by mirage+attack delay
The Howlcrack unique item sets the cooldown of warcies to 0 causing the
GC dps to explode into infinity due to division by zero. This was caused
by the assumption that the mirages instantly spawn and attack. This
commit makes it so that the cooldown is at least the amount of time it
takes to spawm them all and attack or channel for 1s.
* FIX: cleanup handling of limitedSkills table
* FIX: cleanup target skill selection for SacredWisps and MirageArcher
* FIX: mark the cache generated by mirage calcs as CALCULATOR
The env used by mirage skills is often modified causing the resulting
env to differ. This has not caused issues to there not beign any caching
use after calcMirages but this could come up in the future. Marking the
env as CALCULATOR still allows for the env to be cached in case it's
really needed but it will prevent it being used in most cases.
* FIX: remove vestigial CACHE table
This was once used as the main table holding the cached output of
skills. It has been entirely replaced by the remaining tables.
* MISC: typo
* FIX: typo
* Fix Volatility applying to Minion Spell skills
Volatility was not being restricted to minion spells after we recently changed how we were applying support gems to minions
---------
Co-authored-by: Paliak <91493239+Paliak@users.noreply.github.com>
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
* Added beastcrafts to item crafter
* Fixed a formatting issue
* Formatting
* Fix end block
* Remove Flask mods as they are the exact same as t3 regular mods
* Move
---------
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
* FIX(mirage): fix cap GC cooldown by mirage+attack delay
The Howlcrack unique item sets the cooldown of warcies to 0 causing the
GC dps to explode into infinity due to division by zero. This was caused
by the assumption that the mirages instantly spawn and attack. This
commit makes it so that the cooldown is at least the amount of time it
takes to spawm them all and attack or channel for 1s.
* FIX: cleanup handling of limitedSkills table
* FIX: cleanup target skill selection for SacredWisps and MirageArcher
* FIX: mark the cache generated by mirage calcs as CALCULATOR
The env used by mirage skills is often modified causing the resulting
env to differ. This has not caused issues to there not beign any caching
use after calcMirages but this could come up in the future. Marking the
env as CALCULATOR still allows for the env to be cached in case it's
really needed but it will prevent it being used in most cases.
* FIX: remove vestigial CACHE table
This was once used as the main table holding the cached output of
skills. It has been entirely replaced by the remaining tables.
* MISC: typo
* FIX: typo
Kalandra's Touch now copies the influence from the other ring
Also realised that this has always been slightly broken as it was not using the correct names for the conqueror mods
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
We didn't update Cinderswallow when it was changed in 3/26 to add some new mods and remove old ones
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
