overspend1/PathOfBuilding
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Correct skill slot comparison for General's Cry detection (#8954)

Browse Source 
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
This commit is contained in:
Emmanuel Ferdman
2025-08-20 05:41:59 +03:00
committed by GitHub
parent f00fa649c1
commit e6677c9371
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Modules/CalcMirages.lua
View File

@@ -374,7 +374,7 @@ function calcs.mirages(env)
-- Find the active General's Cry gem to get active properties
for _, skill in ipairs(env.player.activeSkillList) do
if skill.activeEffect.grantedEffect.name == "General's Cry" and env.player.mainSkill.socketGroup.slot == env.player.mainSkill.socketGroup.slot then
if skill.activeEffect.grantedEffect.name == "General's Cry" and skill.socketGroup.slot == env.player.mainSkill.socketGroup.slot then
cooldown = calcSkillCooldown(skill.skillModList, skill.skillCfg, skill.skillData)
generalsCryActiveSkill = skill
break
@@ -397,7 +397,7 @@ function calcs.mirages(env)
env.player.mainSkill.skillData.timeOverride = 1
end
-- This is so that it's consistant with the info message but removing this could make it more accurate numbers wise
-- This is so that it's consistent with the info message but removing this could make it more accurate numbers wise
mirageSpawnTime = round(mirageSpawnTime, 2)
cooldown = m_max(cooldown, mirageSpawnTime)