* FEAT(items): Add showcased uniques to New.lua
* FEAT(mods): add handling for new mods on Scornflux
* FEAT(mods): add handling for "Take X Fire Damage when you use a Skill"
* FEAT(mods): add handling for Damage penetrates "Fire Resistance equal to
your overcapped Fire Resistance"
* FEAT(mods): add handling for "Warcries have an additional Life Cost equal to 15% of your Maximum Life"
* FEAT(mods): add handling for "Warcry Skills have X increased Area of
Effect"
* FEAT(mods): add handling for `Gain no armour from equipped body armour`
* FEAT(mods): port generalized "doubled" mod handling from POB2
https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/1095
* Update spelling and ModCache
* FIX(mods): globalLimit style mods did not work sometimes
When a mod gots pice wise parsed the tags can be added to the mod table
in unpredictable order. The inital implementation was simply checking
the first tag which caused the global limit functionality to not work
sometimes. This commit moves the logic into EvalMod.
* FEAT(mods): add support for "you have no Str/Dex" mods
* FIX(spelling): un-rake-able
---------
Co-authored-by: Wires77 <Wires77@users.noreply.github.com>
* increase flexibility in parsing for ESIncBySpellBlock on 3.26 Vile Bastion
* Update wording to not need the optional bit
* Update tests
---------
Co-authored-by: Wires77 <Wires77@users.noreply.github.com>
* FEAT(items): Add showcased uniques to New.lua
* FEAT(mods): add handling for new mods on Scornflux
* FEAT(mods): add handling for "Take X Fire Damage when you use a Skill"
* FEAT(mods): add handling for Damage penetrates "Fire Resistance equal to
your overcapped Fire Resistance"
* FEAT(mods): add handling for "Warcries have an additional Life Cost equal to 15% of your Maximum Life"
* FEAT(mods): add handling for "Warcry Skills have X increased Area of
Effect"
* FEAT(mods): add handling for `Gain no armour from equipped body armour`
* FEAT(mods): port generalized "doubled" mod handling from POB2
https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/1095
* Update spelling and ModCache
---------
Co-authored-by: Wires77 <Wires77@users.noreply.github.com>
* start adding unique changes
* easy uniques done
* more uniques
* updated ModCache
* Devouring Diadem
* Skills changes for the following uniques:
The Icicle Burst skill triggered by the Cameria's Avarice Unique One Handed Mace now has a cooldown of 0.3 seconds (from 0.5 seconds) and deals 200% of base and added damage (previously 150%).
The Divinity Buff granted by the Garb of the Ephemeral Unique Body Armour now grants 75% more Elemental Damage (previously 50%) and 25% less Elemental Damage taken (previously 20%).
The Void Shot Skill granted by the Voidfletcher Unique Quiver now deals 100% more Area Damage (previously 25%).
* whitespace
* undo changes to autogenerated files
* fixed corrupted Blood immunity wording
* update ModCache
* Fix a few misses in 3.26 unique changes
* Update ModCache
---------
Co-authored-by: Wires77 <Wires77@users.noreply.github.com>
* Add 3_26 standard and ruthless trees as per release.md guide
* Add alternate version for 3_26 trees, reorder trees to ensure base tree is default
* Update docs with suggestion for naming of alternate/ruthless trees and data json rename
* Fix a contentious word flagged by the spellcheck action
* Switch tree version from poeplanner
---------
Co-authored-by: Wires77 <Wires77@users.noreply.github.com>
* Refresh mod cache at current HEAD
* Add mod parsing and defence calc support for 3.26 Vile Bastion es inc by spell block
* Used mod source in defence calc to fix breakdown sourcing logic on hover
* Fix some whitespace errors
* align es inc by spellblock mod placement and wording to similar mods
The item parsing logic in WIKI mode seems to rely on finding a mod that
produces a modList to set the foundExplicit variable to true which then
allows mods that do not produce a modList to be added to lineList. This
causes issues with items such as Dialla's Malefaction where the first
explicit line does not have any parsing which causes it to not be added
to linesList. Interestingly enough other mods wihch are parsed
piece-wise work fine here as they produce and empty modList with the
extras paramter.
Parsing of the Gem-lined Cap Ascendancy Notable mod "+3 to Level on all non-Exceptional Support Gems" was incorrect due to faulty handling of the hyphen causing "non-exceptional" to be split into two keywords: "non" and "exceptional". This caused the mod to not apply as there does not exist a gem tag called "non". This commit fixes this by improving handling of non space characters in the keyword string and implementing handling for the negation part in "non-exceptional" inside of calcLib.gemIsType function.
The Dominating Blow skill has a simillar issue to the Absolution skill
where increasing count increases not only the "minion count" but also
applies a multiplier on the base skill damage.
This commit essentially copies
https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/4653 and
applies it to Dominating Blow.
Bit of a scuffed way of handling it as we currently don't handle damage gain per weapon but instead only handle it globally atm
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
* Keep Max Price and Max Level between Trade Queries
* Fix use of spaces instead of tabs
---------
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
* Added skill part "Cast" for Hydrosphere, for when the Hydrosphere is continuously recast. Adjusted skill part names for Frozen, Shocked and Frozen & Shocked for clarity.
* Split "Cast" further into Frozen, Shocked and Frozen Shocked skill parts since the damage pulse from casting actually also converts depending on the ailment of the sphere.
* Fix not using tabs
---------
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
The Unique item check wasn't being made for relic uniques so it would bring you to the item base page instead of the unique item page
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Relic flasks were not being checked to also be unique when we merge the buff effects so they were duplicating
Fixed for Tinctures too
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Tinctures were interpreting the CDR mod as a global CDR mod when it's only meant to affect the cooldown of the Tincture itself
The local mod is also additive with the global mod on the tree and was mistakenly being treated as multiplicative with the way we were handling it
They also showed the tooltip for mana burn per second, but the number being shown was the seconds per mana burn. Fixed it to show the rate per second as intended
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
The Gem attack speed multiplier was affecting the reload time of Crossbow skills as it as implemented as a more attack speed mod instead of modifying the base attack rate
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
