overspend1/PathOfBuilding
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add support for Wintertide Brand average DOT calculation (#6868)

Browse Source 
Co-authored-by: Wires77 <Wires77@users.noreply.github.com>
This commit is contained in:
Andrey Goder
2025-06-12 14:32:43 -07:00
committed by GitHub
parent e92708cd8c
commit 2ff5e40ce6
2 changed files with 47 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/Data/Skills/act_int.lua
View File

@@ -19197,12 +19197,34 @@ skills["WintertideBrand"] = {
castTime = 0.7,
preDamageFunc = function(activeSkill, output)
activeSkill.skillData.hitTimeOverride = activeSkill.skillData.repeatFrequency / (1 + activeSkill.skillModList:Sum("INC", activeSkill.skillCfg, "Speed", "BrandActivationFrequency") / 100) / activeSkill.skillModList:More(activeSkill.skillCfg, "BrandActivationFrequency")
if activeSkill.skillPart == 2 then
local skillMaxStages = activeSkill.skillModList:Sum("BASE", activeSkill.skillCfg, "Multiplier:WintertideBrandMaxStages")
local duration = calcSkillDuration(activeSkill.skillModList, activeSkill.skillCfg, activeSkill.skillData, {})
local maxStages = math.min(duration / activeSkill.skillData.hitTimeOverride + 1, skillMaxStages)
local timeToReachMaxStages = (maxStages - 1) * activeSkill.skillData.hitTimeOverride
local timeAtMaxStages = duration - timeToReachMaxStages
local damagePerStage = activeSkill.skillModList:Sum("BASE", activeSkill.skillCfg, "Multiplier:WintertideBrandDamagePerStage")
-- Get the average damage before reaching max stages and then damage at max stages
local dpsMultiplier = ((2 + damagePerStage + maxStages * damagePerStage)/2*timeToReachMaxStages+timeAtMaxStages*(1+maxStages*damagePerStage))/duration
activeSkill.skillModList:NewMod("Damage", "MORE", dpsMultiplier, "Wintertide Brand Average Multiplier")
end
end,
parts = {
{
name = "Manual Stages",
stages = true
},
{
name = "Average Damage",
}
},
statMap = {
["base_skill_show_average_damage_instead_of_dps"] = {
},
["immolation_brand_burn_damage_+%_final_per_stage"] = {
mod("Damage", "MORE", nil, 0, 0, { type = "Multiplier", var = "WintertideBrandStage", limitVar = "WintertideBrandMaxStages" }),
-- Only apply to Manual Stages part
mod("Damage", "MORE", nil, 0, 0, { type = "Multiplier", var = "WintertideBrandStage", limitVar = "WintertideBrandMaxStages" }, { type = "SkillPart", skillPart = 1 }),
mod("Multiplier:WintertideBrandDamagePerStage", "BASE", nil),
},
["winter_brand_max_number_of_stages"] = {
mod("Multiplier:WintertideBrandMaxStages", "BASE", nil),

26
src/Export/Skills/act_int.txt
View File

@@ -4083,12 +4083,34 @@ local skills, mod, flag, skill = ...
#flags spell area duration brand
preDamageFunc = function(activeSkill, output)
activeSkill.skillData.hitTimeOverride = activeSkill.skillData.repeatFrequency / (1 + activeSkill.skillModList:Sum("INC", activeSkill.skillCfg, "Speed", "BrandActivationFrequency") / 100) / activeSkill.skillModList:More(activeSkill.skillCfg, "BrandActivationFrequency")
if activeSkill.skillPart == 2 then
local skillMaxStages = activeSkill.skillModList:Sum("BASE", activeSkill.skillCfg, "Multiplier:WintertideBrandMaxStages")
local duration = calcSkillDuration(activeSkill.skillModList, activeSkill.skillCfg, activeSkill.skillData, {})
local maxStages = math.min(duration / activeSkill.skillData.hitTimeOverride + 1, skillMaxStages)
local timeToReachMaxStages = (maxStages - 1) * activeSkill.skillData.hitTimeOverride
local timeAtMaxStages = duration - timeToReachMaxStages
local damagePerStage = activeSkill.skillModList:Sum("BASE", activeSkill.skillCfg, "Multiplier:WintertideBrandDamagePerStage")
-- Get the average damage before reaching max stages and then damage at max stages
local dpsMultiplier = ((2 + damagePerStage + maxStages * damagePerStage)/2*timeToReachMaxStages+timeAtMaxStages*(1+maxStages*damagePerStage))/duration
activeSkill.skillModList:NewMod("Damage", "MORE", dpsMultiplier, "Wintertide Brand Average Multiplier")
end
end,
parts = {
{
name = "Manual Stages",
stages = true
},
{
name = "Average Damage",
}
},
statMap = {
["base_skill_show_average_damage_instead_of_dps"] = {
},
["immolation_brand_burn_damage_+%_final_per_stage"] = {
mod("Damage", "MORE", nil, 0, 0, { type = "Multiplier", var = "WintertideBrandStage", limitVar = "WintertideBrandMaxStages" }),
-- Only apply to Manual Stages part
mod("Damage", "MORE", nil, 0, 0, { type = "Multiplier", var = "WintertideBrandStage", limitVar = "WintertideBrandMaxStages" }, { type = "SkillPart", skillPart = 1 }),
mod("Multiplier:WintertideBrandDamagePerStage", "BASE", nil),
},
["winter_brand_max_number_of_stages"] = {
mod("Multiplier:WintertideBrandMaxStages", "BASE", nil),
@@ -4148,4 +4170,4 @@ local skills, mod, flag, skill = ...
},
},
#baseMod skill("radius", 40)
#mods
#mods