* FIX(mirage): fix cap GC cooldown by mirage+attack delay
The Howlcrack unique item sets the cooldown of warcies to 0 causing the
GC dps to explode into infinity due to division by zero. This was caused
by the assumption that the mirages instantly spawn and attack. This
commit makes it so that the cooldown is at least the amount of time it
takes to spawm them all and attack or channel for 1s.
* FIX: cleanup handling of limitedSkills table
* FIX: cleanup target skill selection for SacredWisps and MirageArcher
* FIX: mark the cache generated by mirage calcs as CALCULATOR
The env used by mirage skills is often modified causing the resulting
env to differ. This has not caused issues to there not beign any caching
use after calcMirages but this could come up in the future. Marking the
env as CALCULATOR still allows for the env to be cached in case it's
really needed but it will prevent it being used in most cases.
* FIX: remove vestigial CACHE table
This was once used as the main table holding the cached output of
skills. It has been entirely replaced by the remaining tables.
* MISC: typo
* FIX: typo
Kalandra's Touch now copies the influence from the other ring
Also realised that this has always been slightly broken as it was not using the correct names for the conqueror mods
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
We didn't update Cinderswallow when it was changed in 3/26 to add some new mods and remove old ones
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
The Starting nodes from ascendant are within the radius of the jewels and were not checking for the ClassStart attribute to be false
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Ancestral Bond does not apply to mirages
Not 100% if this is the best place to put the condition
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
In 3.26 it was changed so that Devouring Diadem uses prefix veiled mods instead of suffix ones
Also added support for the crit damage mod
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
We never updated the unique talismans with their catalyst tags after tainted catalysts were added to the game
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Linking Enfeeble to High Impact Mine caused sources of Increased Mine Aura effect to scale the curse effect on Enfeeble
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
* Revert "Moving the Dot Multiplier on crit to be common for all actors (#8826)"
This reverts commit 4fe61a930c.
* Adjust minion DoT multiplier from critical hits
* Add support for Replica Dragonfang's Flight variants
Generate Variants for Replica Dragonfang's Flight
* Remove current implementation for Replica Dragonfang's Flight
* remove range from generation
* Fix Runegraft of the Bound scaling Facebreaker's incorrectly
The mod was scaling the more multiplier on the gloves incorrectly by adding another More multiplier mod instead of modifying the existing mod
This change also made me realise that we sometime incorrectly handle mods when the are 2 instances of them on an item
e.g. T1 Life + crafted hybrid life shows up as 2 mods on the item so we process them in 2 loops which results in the rounding being incorrect
Would have to somehow merge all similar mods on an item first then loop though them to fix it I think
* Fix split mod rounding issues and move logic with other scaling logic
* Hack fix for getting mod data from the tree
* Remove old block
---------
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Co-authored-by: Wires77 <Wires77@users.noreply.github.com>
The configs limited the mods by hardcoding the active count value instead of grabbing it from the stat
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
The mods were implemented with values of 100 but those are not needed as the calc defaults to 100 when no default is set
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
* Fix Bound by Destiny Phys prevented as ES Regen mod value
The mods uses a new stat describer format that we didn't support
* ModCache
---------
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
The Brand attachment time is affected by temportal chains so this affects the maximum number of ticks a brand can do. More relevant for Wintertide Brand as we uses the attachment duration for DPS calcs
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
The sort was only using the attribute requirements from the item base instead of including local attribute requirement changing mods like on Akoya's Gaze
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
