Commit Graph

8628 Commits

Author SHA1 Message Date
Tntmister
7ada228a02 Use harmonic mean for attack speed calc instead of average (#8900) 2025-08-01 17:09:08 +10:00
brendan-corrigan
2ec91314aa Hacky fix for Tincture crash (#8905) 2025-08-01 17:02:55 +10:00
Wires77
c9e1bf17b8 Fix #8906: Fix issue where Rage Support was affecting Herald of Purity (#8907) 2025-08-01 16:55:15 +10:00
LocalIdentity
2a5efed4bf Revert PR #8804 as it caused issues
Fixes #8866
Reopens #8042
2025-08-01 16:53:58 +10:00
Paliak
0b8babb506 Fix Howlcrack causing inf DPS with Generals Cry (#8889)
* FIX(mirage): fix cap GC cooldown by mirage+attack delay

The Howlcrack unique item sets the cooldown of warcies to 0 causing the
GC dps to explode into infinity due to division by zero. This was caused
by the assumption that the mirages instantly spawn and attack. This
commit makes it so that the cooldown is at least the amount of time it
takes to spawm them all and attack or channel for 1s.

* FIX: cleanup handling of limitedSkills table

* FIX: cleanup target skill selection for SacredWisps and MirageArcher

* FIX: mark the cache generated by mirage calcs as CALCULATOR

The env used by mirage skills is often modified causing the resulting
env to differ. This has not caused issues to there not beign any caching
use after calcMirages but this could come up in the future. Marking the
env as CALCULATOR still allows for the env to be cached in case it's
really needed but it will prevent it being used in most cases.

* FIX: remove vestigial CACHE table

This was once used as the main table holding the cached output of
skills. It has been entirely replaced by the remaining tables.

* MISC: typo

* FIX: typo
2025-08-01 16:49:42 +10:00
LocalIdentity
57552c71d7 Fix Kaladra's Touch not copying influence from other ring (#8888)
Kalandra's Touch now copies the influence from the other ring
Also realised that this has always been slightly broken as it was not using the correct names for the conqueror mods

Co-authored-by: LocalIdentity <localidentity2@gmail.com>
2025-07-23 03:24:36 +10:00
LocalIdentity
5ca6591f99 Add support for new Cinderswallow mods (#8886)
We didn't update Cinderswallow when it was changed in 3/26 to add some new mods and remove old ones

Co-authored-by: LocalIdentity <localidentity2@gmail.com>
2025-07-23 03:24:29 +10:00
tserdar
d5e938fb47 Add total minimum weights parameter and logic to timeless jewel finder to filter out results that are below this value (#8787) 2025-07-22 02:54:02 +10:00
kisiex
f1a6ca5169 Added support for Chieftain's Ramako, Sun's Light notable (Ruthless version) (#8808)
* Added support for Chieftain's Ramako, Sun's Light notable

* Add ModParser support

---------

Co-authored-by: LocalIdentity <localidentity2@gmail.com>
2025-07-22 02:51:17 +10:00
Blitz54
9e283b5f1b Display unit distance for AOE (#8845) 2025-07-22 02:40:55 +10:00
Blitz54
51f647957d Show Flask Slot for UniqueDB Comparisons (#8871) 2025-07-22 02:40:28 +10:00
Linus Alpsten
2c73353ac8 Add tags to Whispers of Infinity (#8843)
For quality/catalysts
2025-07-22 02:39:14 +10:00
Wires77
0ed1dd8bb4 Fix rounding of scaled mods being incorrect in some cases (#8862)
* Fixes #8860: Rounding of scaled mods was incorrect in some cases

* Don't include boolean or table mods
2025-07-22 02:38:32 +10:00
NL
bf3de469ac Fix tincture quality rounding issue (#8874) 2025-07-22 02:38:07 +10:00
LocalIdentity
81e0b5537f Fix Light of Meaning double counting starting nodes on Ascendant (#8875)
The Starting nodes from ascendant are within the radius of the jewels and were not checking for the ClassStart attribute to be false

Co-authored-by: LocalIdentity <localidentity2@gmail.com>
2025-07-22 02:37:43 +10:00
LocalIdentity
994d17ddf4 Fix Hand of Phrecia disabling Mine Auras (#8876)
I'm pretty sure this doesn't break something else

Co-authored-by: LocalIdentity <localidentity2@gmail.com>
2025-07-22 02:37:33 +10:00
LocalIdentity
ec49dafa32 Fix Ancestral Bond disabling Generals Cry damage (#8877)
Ancestral Bond does not apply to mirages
Not 100% if this is the best place to put the condition

Co-authored-by: LocalIdentity <localidentity2@gmail.com>
2025-07-22 02:37:25 +10:00
LocalIdentity
5c0849a343 Fix Devouring Diadem in unique list using suffix veiled mods (#8878)
In 3.26 it was changed so that Devouring Diadem uses prefix veiled mods instead of suffix ones
Also added support for the crit damage mod

Co-authored-by: LocalIdentity <localidentity2@gmail.com>
2025-07-22 02:37:14 +10:00
LocalIdentity
0c34b40e5f Fix Betrayal's Sting and Unique Talisman's missing catalyst scaling (#8882)
We never updated the unique talismans with their catalyst tags after tainted catalysts were added to the game

Co-authored-by: LocalIdentity <localidentity2@gmail.com>
2025-07-22 02:37:03 +10:00
LocalIdentity
63bf8698b2 Fix Mine Aura effect scaling linked curses (#8883)
Linking Enfeeble to High Impact Mine caused sources of Increased Mine Aura effect to scale the curse effect on Enfeeble

Co-authored-by: LocalIdentity <localidentity2@gmail.com>
2025-07-22 02:36:56 +10:00
Wires77
7d8cfef4a0 Fix flipped keystone versions on Mutewind Pennant 2025-07-18 00:02:01 -05:00
github-actions[bot]
161fe660fc Release 2.55.5 (#8859)
VERSION[2.55.5][2025/07/18]
--- New to Path of Building ---
* Add support for Replica Dragonfang's Flight variants (linusalpsten)

--- Fixed Crashes ---
* Fix Autoexertion modifying active skill tables (Paliak)

--- Fixed Calculations ---
* Fix various node scaling issues (Wires77)
* Fix missing Minion DoT multiplier from critical hits (Wires77)

--- Fixed Behaviours ---
* Fix issue where socketed gem modifiers were scalable by Runegraft of the Bound (Wires77)
* Fix Iron Mass giving Skeletons Triple Damage in Offhand (Blitz54)
---------

Co-authored-by: Wires77 <Wires77@users.noreply.github.com>
2025-07-17 22:04:15 -05:00
Wires77
f918743582 Fix missing Minion DoT multiplier from critical hits (#8841)
* Revert "Moving the Dot Multiplier on crit to be common for all actors (#8826)"

This reverts commit 4fe61a930c.

* Adjust minion DoT multiplier from critical hits
2025-07-17 21:56:00 -05:00
Blitz54
ac5a7b56df Fix iron mass triple damage in offhand (#8846)
Co-authored-by: Wires77 <Wires77@users.noreply.github.com>
2025-07-17 21:54:45 -05:00
Wires77
79b5dc8fba Fixes 8837: Socketed gem modifiers shouldn't be scalable (#8844) 2025-07-17 21:32:49 -05:00
Paliak
1af4607c39 FIX(triggers): fix crash caused by incorrect table assignement (#8852) 2025-07-17 21:32:15 -05:00
Wires77
e9d0605893 Revert "Fix #1149: Cluster jewel scaling causes rounding issues (#8821)" (#8858)
This reverts commit e5230c5c23.
2025-07-17 21:20:50 -05:00
Linus Alpsten
d2ffc43940 Add support for Replica Dragonfang's Flight variants (#8747)
* Add support for Replica Dragonfang's Flight variants

Generate Variants for Replica Dragonfang's Flight

* Remove current implementation for Replica Dragonfang's Flight

* remove range from generation
2025-07-14 22:38:09 -05:00
LocalIdentity
afb958ad39 Merge branch 'master' into dev 2025-07-14 17:27:22 +10:00
LocalIdentity
cc6e4c44ad Release 2.55.4
--- New to Path of Building ---
* Add support for Corrupted Blood flask mods (Blitz54)
* Add support for Righteous Fire of Arcane Devotion more Cast Speed mod (oskar94)

--- Fixed Crashes ---
* Fix Crash when copying and pasting item into PoB sometimes (Nightblade)

--- User Interface ---
* Fix Attribute Requirement sorting (Blitz54)
* Remove Channelling time config box for Focused Channelling - Existing users should update their config (Wires77)
* Fix gems being added to skill groups when sorting dropdown (Paliak)

--- Fixed Calculations ---
* Fix Runegraft of the Bound scaling Facebreaker's incorrectly (LocalIdentity, Wires77)
* Fix Minion Scaling mods on Spinehail scaling with Widowhail (LocalIdentity)
* Fix Full DPS depending on order of skill groups (Paliak)
* Fix Spark maximum hits being calculated incorrectly (jeremykvlim)
* Fix Minion DoT DPS not including +50% DoT multiplier from Crits (Wires77)
* Fix Aura effect scaling when using Hand of Phrecia and  "effect of auras on you" mods (Wires77)
* Fix inc effect on Cluster Jewel causing rounding issues (Wires77)

--- Fixed Behaviours ---
* Fix Autoexertion not working correctly with Arrogance (Paliak)
* Fix Summon Spider / Spectral Wolf count config not scaling with Dark Monarch (LocalIdentity)
* Fix Brand attachment duration not being scaled by Temporal Chains (LocalIdentity)
* Fix Reduced Effect of Curses on Self scaling beyond 100% reduced effect (Blitz54)
* Fix Maven Memory Game skill breaking Vile Bastion from working (Blitz54)
* Fix Nametaker not instant leeching Mana and Energy Shield (Blitz54)
* Fix Item sort option for "Current Usable" not taking into account local attribute requirement mods (LocalIdentity)
* Fix Plague Bearer default config not applying (Blitz54)

--- Accuracy Improvements ---
* Fix Bound by Destiny Phys prevented as ES Regen mod value (LocalIdentity)
2025-07-14 17:13:26 +10:00
LocalIdentity
8fa98f5647 Merge branch 'dev' 2025-07-14 17:12:46 +10:00
github-actions[bot]
60ac32effd Release 2.55.4 (#8834)
* Prepare release 2.55.4

* Fix changelogs

---------

Co-authored-by: LocalIdentity <LocalIdentity@users.noreply.github.com>
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
2025-07-14 17:12:11 +10:00
LocalIdentity
20d34eda06 Export from files 2025-07-14 16:51:12 +10:00
LocalIdentity
b1bdc195c1 Fix Runegraft of the Bound scaling Facebreaker's incorrectly (#8820)
* Fix Runegraft of the Bound scaling Facebreaker's incorrectly

The mod was scaling the more multiplier on the gloves incorrectly by adding another More multiplier mod instead of modifying the existing mod
This change also made me realise that we sometime incorrectly handle mods when the are 2 instances of them on an item
e.g. T1 Life + crafted hybrid life shows up as 2 mods on the item so we process them in 2 loops which results in the rounding being incorrect
Would have to somehow merge all similar mods on an item first then loop though them to fix it I think

* Fix split mod rounding issues and move logic with other scaling logic

* Hack fix for getting mod data from the tree

* Remove old block

---------

Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Co-authored-by: Wires77 <Wires77@users.noreply.github.com>
2025-07-14 16:18:55 +10:00
Blitz54
370a8e64fa Fix Plague Bearer default config not appyling (#8810) 2025-07-14 15:46:21 +10:00
Blitz54
f3b1ae5c49 Fix Nametaker not instant leeching Mana and Energy Shield (#8812) 2025-07-14 15:45:51 +10:00
Blitz54
27b0d5ca5d Fix Attribute Requirement Sorting (#8814) 2025-07-14 15:33:58 +10:00
Wires77
e44f38fd05 Fix aura breakdown values (#8815) 2025-07-14 15:32:26 +10:00
LocalIdentity
8f4a295fde Fix Summon Spider / Spectral Wolf count not scaling with Dark Monarch (#8819)
The configs limited the mods by hardcoding the active count value instead of grabbing it from the stat

Co-authored-by: LocalIdentity <localidentity2@gmail.com>
2025-07-14 15:30:28 +10:00
Wires77
e5230c5c23 Fix #1149: Cluster jewel scaling causes rounding issues (#8821) 2025-07-14 15:29:55 +10:00
Wires77
16a65ae886 Fix #8822: Remove redundant channelling time config (#8823) 2025-07-14 15:27:50 +10:00
Wires77
4fe61a930c Moving the Dot Multiplier on crit to be common for all actors (#8826) 2025-07-14 15:27:00 +10:00
Oskar Wärme
7c11fccb6c Updated Righteous Fire of Arcane Devotion to grant more Cast Speed added in 3.26 (#8830) 2025-07-14 15:26:43 +10:00
Jeremy Lim
9da27c95e2 Fix Spark maximum hits being calculated incorrectly (#8833)
* fix: spark max hits

* fix: spark max hits
2025-07-14 15:26:26 +10:00
Paliak
41de8e67dc FIX: Autoexertion not using active skill cooldown. Misc cleanup. (#8801)
Co-authored-by: LocalIdentity <31035929+LocalIdentity@users.noreply.github.com>
2025-07-08 20:41:42 +10:00
LocalIdentity
7206d7a9b1 Fix Minion Scaling mods on Spinehail scaling with Widowhail (#8779)
The mods were implemented with values of 100 but those are not needed as the calc defaults to 100 when no default is set

Co-authored-by: LocalIdentity <localidentity2@gmail.com>
2025-07-08 20:39:57 +10:00
Blitz54
af700b4792 Fix Maven Memory Game "CannotBeBlocked" (#8781) 2025-07-08 20:39:18 +10:00
Blitz54
914385ce71 Fix Reduced Effect of Curses on Self not clamping (#8783) 2025-07-08 20:38:38 +10:00
Nighty
8292df858a add a null-variable check (#8789) 2025-07-08 20:37:51 +10:00
LocalIdentity
707dd8628f Fix Bound by Destiny Phys prevented as ES Regen mod value (#8795)
* Fix Bound by Destiny Phys prevented as ES Regen mod value

The mods uses a new stat describer format that we didn't support

* ModCache

---------

Co-authored-by: LocalIdentity <localidentity2@gmail.com>
2025-07-08 20:36:49 +10:00