* Fix Runegraft of the Bound scaling Facebreaker's incorrectly
The mod was scaling the more multiplier on the gloves incorrectly by adding another More multiplier mod instead of modifying the existing mod
This change also made me realise that we sometime incorrectly handle mods when the are 2 instances of them on an item
e.g. T1 Life + crafted hybrid life shows up as 2 mods on the item so we process them in 2 loops which results in the rounding being incorrect
Would have to somehow merge all similar mods on an item first then loop though them to fix it I think
* Fix split mod rounding issues and move logic with other scaling logic
* Hack fix for getting mod data from the tree
* Remove old block
---------
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Co-authored-by: Wires77 <Wires77@users.noreply.github.com>
The configs limited the mods by hardcoding the active count value instead of grabbing it from the stat
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
The mods were implemented with values of 100 but those are not needed as the calc defaults to 100 when no default is set
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
* Fix Bound by Destiny Phys prevented as ES Regen mod value
The mods uses a new stat describer format that we didn't support
* ModCache
---------
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
The Brand attachment time is affected by temportal chains so this affects the maximum number of ticks a brand can do. More relevant for Wintertide Brand as we uses the attachment duration for DPS calcs
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
The sort was only using the attribute requirements from the item base instead of including local attribute requirement changing mods like on Akoya's Gaze
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
We don't exclusively have a tag for just minion duration but I had a look and all the actual minion skills have a minion tag along with the CreatesMinion skill type
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Multistrike would only add repeats to skills with the tag on it which broke support for minions skills
It now uses the same criteria that the damage mods do
This also made me realise that the repeat damage config was not working when used with minion skills as we were only setting the condition on the player
So the average repeat damage and final repeat values were completely wrong and the double damage with spells line on Awakened Spell Echo was not working at all with minions
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
The elemental flag for "CritInPast8s" was only false when the "NeverCrit" flag was true instead of checking to see if the skill has any crit chance
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
The buff did not have the tag to let it apply to Totems
I don't know what this tag is even needed for tbh. It's a relic from Openarl 8 years ago
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Currently, it seems the "Ailments never count as being from Critical
Strikes" mod line found on the Elemental Overload keystone is
implemented by simply never running the crit calculation pass when
calculating ailments. This causes the ailment chance to still show up
in the breakdown and cause issues with the Perfect Agony keystone which
makes ailments only apply from crits.
The mod was not parsed and was applying aura debuffs to enemies
Was also applying auras to enemies if you had the new runegraft
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
* Fix Runegraft bonus for Boots / Gloves scaling skill levels
The Runegraft mod only scales mods on items that come from stats, since socketed gem effects are properties of a GrantedEffect, they are not scaled by the bonus effect
* Filter out ExtraSkillMod
---------
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
--- Fixed Crashes ---
* Fix crash when trying to edit Config/Item Set after saving a new Set (Blitz54)
--- Fixed Behaviours ---
* Fix Summoned Phantasm not working correctly when used in Soulwrest (LocalIdentity)
* Fix The Dark Monarch not scaling "per summoned x" mods (LocalIdentity)
* Fix Swift Affliction less duration and damaging ailment duration not applying individually (deathbeam)
* Fix Coiling Whisper applying to all Curses instead of just Hexes (pjo256)
* Fix Runegraft bonus for Boots / Gloves not working (LocalIdentity)
Needs to be handled later to work with nodes on the tree.
Not sure if removing the restriction for scaling a mod below 0 will cause issues elsewhere
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Swift Affliction less duration and less damaging ailment duration do not applies
only once, but applies separately. Testable on Viper Strike of the Mamba in game
for example
Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
The calculation in CalcPerform was only taking into account the base stat for the mod which did not account for the more mod on the helm
It also didn't account for maximum number overrides which it now does
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
The Summon Phantasm gem was modifying the level of the minion from the triggerd phantasm when it should not be doing this
This also fixes the issue where there were 2 summoned phantasm minions in the list
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
