The item parsing logic in WIKI mode seems to rely on finding a mod that
produces a modList to set the foundExplicit variable to true which then
allows mods that do not produce a modList to be added to lineList. This
causes issues with items such as Dialla's Malefaction where the first
explicit line does not have any parsing which causes it to not be added
to linesList. Interestingly enough other mods wihch are parsed
piece-wise work fine here as they produce and empty modList with the
extras paramter.
Parsing of the Gem-lined Cap Ascendancy Notable mod "+3 to Level on all non-Exceptional Support Gems" was incorrect due to faulty handling of the hyphen causing "non-exceptional" to be split into two keywords: "non" and "exceptional". This caused the mod to not apply as there does not exist a gem tag called "non". This commit fixes this by improving handling of non space characters in the keyword string and implementing handling for the negation part in "non-exceptional" inside of calcLib.gemIsType function.
The Dominating Blow skill has a simillar issue to the Absolution skill
where increasing count increases not only the "minion count" but also
applies a multiplier on the base skill damage.
This commit essentially copies
https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/4653 and
applies it to Dominating Blow.
Bit of a scuffed way of handling it as we currently don't handle damage gain per weapon but instead only handle it globally atm
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
* Keep Max Price and Max Level between Trade Queries
* Fix use of spaces instead of tabs
---------
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
* Added skill part "Cast" for Hydrosphere, for when the Hydrosphere is continuously recast. Adjusted skill part names for Frozen, Shocked and Frozen & Shocked for clarity.
* Split "Cast" further into Frozen, Shocked and Frozen Shocked skill parts since the damage pulse from casting actually also converts depending on the ailment of the sphere.
* Fix not using tabs
---------
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
The Unique item check wasn't being made for relic uniques so it would bring you to the item base page instead of the unique item page
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Relic flasks were not being checked to also be unique when we merge the buff effects so they were duplicating
Fixed for Tinctures too
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Tinctures were interpreting the CDR mod as a global CDR mod when it's only meant to affect the cooldown of the Tincture itself
The local mod is also additive with the global mod on the tree and was mistakenly being treated as multiplicative with the way we were handling it
They also showed the tooltip for mana burn per second, but the number being shown was the seconds per mana burn. Fixed it to show the rate per second as intended
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
The Gem attack speed multiplier was affecting the reload time of Crossbow skills as it as implemented as a more attack speed mod instead of modifying the base attack rate
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
* Added the ability to change max node depth for heat map calculation to a custom value
* Fixed visibility of controls on TreeTab at minimum screen width
Skill gems should scale the damage from the ground DoT but were not as we did not add any skill tags to the effect
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
The mod was previously hard-coded to only work with the 20% value from Siegebreaker. Fixed it to use a percent stat value that comes from the mod
Also fixed it for replica siege breaker in case that ever becomes an issue too
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Herald of Ash was previously scaling with area and spell damage mods which it shouldn't it was also possible for the increased damage values to be negative which is not correct.
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Ward is granted even with values above 100 but the conversion for armour / evasion on gear is capped at 100%
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
