overspend1/PathOfBuilding
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix Minion supports not scaling Siegebreaker ground DoT (#8552)

Browse Source 
Skill gems should scale the damage from the ground DoT but were not as we did not add any skill tags to the effect

Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This commit is contained in:
LocalIdentity
2025-03-06 02:07:34 +11:00
committed by GitHub
parent f6b5147eae
commit f258c1fadc
2 changed files with 10 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/Data/Skills/minion.lua
View File

@@ -1561,11 +1561,10 @@ skills["SiegebreakerCausticGround"] = {
hidden = true,
color = 4,
baseFlags = {
cast = true,
area = true,
chaos = true,
duration = true,
},
skillTypes = { },
skillTypes = { [SkillType.Spell] = true, [SkillType.Duration] = true, [SkillType.Damage] = true, [SkillType.Area] = true, [SkillType.DamageOverTime] = true, [SkillType.Triggerable] = true, [SkillType.Chaos] = true, [SkillType.AreaSpell] = true, },
baseMods = {
skill("ChaosDot", 1, { type = "PercentStat", stat = "Life", percentVar = "SiegebreakerCausticGroundPercent" }),
skill("dotIsArea", true),
@@ -1584,11 +1583,10 @@ skills["ReplicaSiegebreakerBurningGround"] = {
hidden = true,
color = 4,
baseFlags = {
cast = true,
area = true,
fire = true,
duration = true,
},
skillTypes = { },
skillTypes = { [SkillType.Spell] = true, [SkillType.Duration] = true, [SkillType.Damage] = true, [SkillType.Area] = true, [SkillType.DamageOverTime] = true, [SkillType.Triggerable] = true, [SkillType.Fire] = true, [SkillType.AreaSpell] = true, [SkillType.CausesBurning] = true, },
baseMods = {
skill("FireDot", 1, { type = "PercentStat", stat = "Life", percentVar = "SiegebreakerBurningGroundPercent" }),
skill("dotIsArea", true),

14
src/Export/Skills/minion.txt
View File

@@ -289,13 +289,12 @@ skills["SiegebreakerCausticGround"] = {
hidden = true,
color = 4,
baseFlags = {
cast = true,
area = true,
chaos = true,
duration = true,
},
skillTypes = { },
skillTypes = { [SkillType.Spell] = true, [SkillType.Duration] = true, [SkillType.Damage] = true, [SkillType.Area] = true, [SkillType.DamageOverTime] = true, [SkillType.Triggerable] = true, [SkillType.Chaos] = true, [SkillType.AreaSpell] = true, },
baseMods = {
skill("ChaosDot", 1, { type = "PercentStat", stat = "Life", percentVar = "CausticGroundPercent" }),
skill("ChaosDot", 1, { type = "PercentStat", stat = "Life", percentVar = "SiegebreakerCausticGroundPercent" }),
skill("dotIsArea", true),
flag("dotIsCausticGround"),
},
@@ -312,13 +311,12 @@ skills["ReplicaSiegebreakerBurningGround"] = {
hidden = true,
color = 4,
baseFlags = {
cast = true,
area = true,
fire = true,
duration = true,
},
skillTypes = { },
skillTypes = { [SkillType.Spell] = true, [SkillType.Duration] = true, [SkillType.Damage] = true, [SkillType.Area] = true, [SkillType.DamageOverTime] = true, [SkillType.Triggerable] = true, [SkillType.Fire] = true, [SkillType.AreaSpell] = true, [SkillType.CausesBurning] = true, },
baseMods = {
skill("FireDot", 1, { type = "PercentStat", stat = "Life", percentVar = "BurningGroundPercent" }),
skill("FireDot", 1, { type = "PercentStat", stat = "Life", percentVar = "SiegebreakerBurningGroundPercent" }),
skill("dotIsArea", true),
flag("dotIsBurningGround"),
},