Commit Graph

6647 Commits

Author SHA1 Message Date
Lily
04b968fb54 Doc to explain passes and outputs in CalcOffence (#5392)
* Add a doc to explain passes and outputs

* Formatting issues
2022-12-28 23:49:00 -06:00
Devin Korb
14a79e38d9 add search trade for timeless jewels (#5402)
* add search trade for timeless jewels

* change to get parameter

* change to 50 seeds max

* remove tradequerysearch

* allow shift-click selecting multiple rows in timeless jewel trade search

* IsRowHighlighted -> SetHighlightColor(index, value)

* clean up code

* rename button label after clicking once

* fix re-searching causing it to copy the last trades

* fix backwards searching and make logic simpler

* remove tradequeryrequests from treetab

* nit: style fixes

Co-authored-by: Wires77 <Wires77@users.noreply.github.com>
2022-12-28 23:44:58 -06:00
Paliak
a26db10d49 FIX: best match parsing of item base type (#5452) 2022-12-28 22:20:54 -06:00
Paliak
7ca4fd6923 Minor renaming to improve clarity (#5468)
* FIX: minor renaming to improve clarity

* FIX: spellcheck
2022-12-28 21:35:32 -06:00
Tomas Slusny
31798a35f7 Apply enemy damage multiplier to max hit taken (#5424)
Signed-off-by: Tomas Slusny <slusnucky@gmail.com>

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
2022-12-29 05:50:34 +11:00
Dullson
cdd6fe2936 Fix Trader memoryleak caused by OnFrame functions (#5473)
* fix(pobtrader): memoryleak caused by unsubbed OnFrame functions

* style(pobtrader): fix indentation
2022-12-29 03:29:58 +11:00
Dullson
bfc5eb8314 PoB Trader: fix indentation (#5478) 2022-12-29 03:27:31 +11:00
Paliak
9cc6292231 Fix: Deleting gem level causing a crash (#5479) 2022-12-29 03:26:42 +11:00
Tomas Slusny
ab26f47ce2 Add name to elemental damage Grand Spectrum variant (#5481)
Every other variant is properly named.

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
2022-12-29 03:25:22 +11:00
QuickStick
3f843fb2f0 Fix singular element modes not working with phys as random element (#5465) 2022-12-27 04:03:12 +11:00
QuickStick
b478271579 Fixed messed up contents for profiler (#5466) 2022-12-27 04:01:34 +11:00
Regisle
00b0965f1f Update other Militant Faith cost mod (#5469) 2022-12-27 04:00:28 +11:00
QuickStick
155cdfc16e Fix modCache not being used during startup causing long loading times (#5461) 2022-12-26 03:29:49 +11:00
LocalIdentity
03ba68d978 Fix Timeless Jewel tree effect not appearing sometimes (#5440)
When Timeless Jewels are added from the "Find Timeless Jewel" section, the jewel number and name are added to the end of the jewel title. This broke the exact match we were doing to display the jewel radius sprite

Co-authored-by: LocalIdentity <localidentity2@gmail.com>
2022-12-25 23:57:37 +11:00
Paliak
75ce10cd25 Fix Implicit mods on Kalandra's Touch not applying. (#5445)
* FIX: implicits not applying

* FIX: dont relfect other ring mods if other is Kalandra's

* FIX: crash when there's no other ring.
2022-12-25 23:57:00 +11:00
Regisle
ce56331337 Militant Faith update skill cost to mana cost (#5460) 2022-12-25 23:53:42 +11:00
QuickStick
dc5aa7b765 Fix more than 100% reduced resistances causing negative res to turn postive (#5458) 2022-12-25 17:56:19 +11:00
QuickStick
c51af3d028 Update tree to 3.20.1 2022-12-25 17:55:03 +11:00
Paliak
a5d9d332da FIX: exerts applying to triggered skills (#5446) 2022-12-24 20:33:49 +11:00
LocalIdentity
00d11210f4 Remove line 2022-12-24 19:45:33 +11:00
QuickStick
2eb9a39dad Remove legacy Crystalised Omniscience that no longer exists (#5447) 2022-12-24 17:46:42 +11:00
QuickStick
145a3e9717 Fix kalandra's touch not working (#5442)
* Fix old item base

* Update test as well
2022-12-24 15:29:34 +11:00
QuickStick
52ed14f595 Fix profiler crashing (#5439)
Add warning to console on dev

Update Common.lua
2022-12-23 21:18:18 +11:00
QuickStick
286e0334cf Implement profiler toggling on pause (#5434)
* Implement debugger toggling on pause

* Fix accidently deleting the key stuff

* Using the profiler

* Fix bullet points

* Fix up a couple more bugs

* Couple more cleanups

* update profiling usage and file name info

* remove redudant "a profiler"
2022-12-23 18:38:22 +11:00
blahblahdrugs
69f3572110 Clarified instructions for adding EmmyLua to VSCode (#5431)
* Clarified instructions for adding EmmyLua to VSCode

* Fix formatting

Co-authored-by: LocalIdentity <localidentity2@gmail.com>
2022-12-23 18:35:56 +11:00
Fabere456
a3962d7d96 +Flask effect works with silver flask (#5407)
* Update CalcPerform.lua

* Fixes increased effect on the flasks itself so it should properly calculate

-Rotgut is still an issue
-If onslaught is from another source and a flask has reduced effect, the flask overrides the other source. This is incorrect as the stronger effect should override

* Update CalcPerform.lua

added in break

* Makes highest flask always apply

* Fix typos

Co-authored-by: LocalIdentity <31035929+LocalIdentity@users.noreply.github.com>
2022-12-23 18:15:19 +11:00
QuickStick
4f08a93893 Remove duplicate config option (#5420) 2022-12-22 03:11:10 +11:00
QuickStick
365b19b5d6 Fix full dps not working in certain sitatations (#5421) 2022-12-22 03:10:17 +11:00
QuickStick
c59a8da147 Fix relic uniques mod parsing changing (#5423) 2022-12-22 03:09:17 +11:00
QuickStick
8ba5c3680d Update wording on Sandstorm Visage(#5425) 2022-12-22 01:14:08 +11:00
QuickStick
bf374ca40c Add Original Sin (#5426) 2022-12-22 01:13:33 +11:00
ProphetLamb
3aefd6bec0 Add missing physical tag to Heartbound Loop (#5416)
Remove tailing whitespace
2022-12-21 02:16:55 +11:00
QuickStick
9fd605770c Add Sanctum unique drop locations (#5414) 2022-12-20 19:56:15 +11:00
QuickStick
27f30cb8f5 Fix unarmmed not setting crit to zero (#5415) 2022-12-20 19:55:13 +11:00
Nostrademous
f9666a39c5 Feat: add realm support; no support for currency conversion (#5372)
* Feat: add realm support; no support for currency conversion

* Fix: make PS4 work; fix PC

* Adjust labels to be capitalised

* Mistake

* Fix: save drop-down seletion within a session

Co-authored-by: LocalIdentity <localidentity2@gmail.com>
2022-12-20 07:18:34 +11:00
Lily
684bc98793 Support for Frozen Sweep DPS and burst damage (#5296)
* Initial support for Frozen Sweep DPS

* Generalize calculations and add generic burst

* Move calculations to preDamageFunc

* Clean up some format issues

* Improvements from review

* Properly take all feedback

* Extra digit in burst damage breakdown

* Support for additional CD uses

* Correct flags and display cast/attack speed
2022-12-20 07:04:37 +11:00
Andrew B
25f427050e Critical cull chance uses hit rate (#5378)
* critical cull chance uses hit rate

* Move lines

Co-authored-by: LocalIdentity <localidentity2@gmail.com>
2022-12-20 06:51:32 +11:00
Andrew B
75128927b4 Add support for Sandstorm Visage crit mod (#5398)
* Add support for Sandstorm Visage crit override

* Add breakdown message

* Change name of base crit from weapon var
2022-12-20 06:37:26 +11:00
Edvinas-Smita
58423af568 Adjusted seismic and spire wave count calculation (#5395)
* Adjusted seismic and spire wave count calculation

Turns out that server tick rate does not play a role in seismic (and spire) waves count calculations.

* Missed act_int.lua when moving colour codes
2022-12-20 06:35:12 +11:00
pHiney
bea398820a Ensure item base type follows item title for unique items (#5306)
* Ensure item base type follows item title

* Missed two

* Two more

Co-authored-by: Hiney <pHiney@users.noreply.github.com>
2022-12-20 06:29:13 +11:00
Andrew B
356243b63c Add support for Phantasmal Reave radius (#5374)
* Update Reave radius for large phantasmal quality

* add to txt file

* Revert line deletion

Co-authored-by: LocalIdentity <31035929+LocalIdentity@users.noreply.github.com>
2022-12-20 06:26:01 +11:00
Andrew B
db386f846a Add support for mutewind pennant warcry mod (#5384) 2022-12-19 23:28:49 +11:00
LocalIdentity
4a5bd7584d Export new stat descriptions 2022-12-19 23:28:06 +11:00
LocalIdentity
3755e2021d Fix Rotgut mods (#5410)
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
2022-12-19 22:57:55 +11:00
Dolmur
692e76c16c Query Options Improvements (#5379)
* Update TradeQueryGenerator.lua

fixed automated min weight for builds that don't use Full DPS or Total DPS

* Update TradeQueryGenerator.lua

missed parentheses

* Fix for minion mods not being considered for "Find Best" tool

There were three weightKeys (weapon_can_roll_minion_modifiers, ring_can_roll_minion_modifiers, focus_can_roll_minion_modifiers) which were not being considered for their respective slots. They have been added to the appropriate entries of itemCategoryTags.

Also updated special case statOrders and regenerated QueryMods.lua

* Query Options Improvements

* The checkbox for eldritch mods is now only shown for slots that can have them on non-unique items
* Disabled the checkbox for synthesis mods for now, as they are not supported
2022-12-19 22:39:15 +11:00
Dullson
2d506c0c83 Improve item pricer error handling (#5396)
* fix(pobtrader): improve error handling

* fix(pobtrader): add generator error when it returns no filters instead of invalid search

* fix(pobtrader): encode spaces on league names for urls
2022-12-19 22:38:13 +11:00
Regisle
6316cf203d Use default item affix quality rather than 50% (#5388) 2022-12-19 22:37:06 +11:00
LocalIdentity
58bb70c83d Fix Divergent Cast while Channeling adding "More" damage (#5409)
The Divergent quality is only meant to scale ailment effect and it seems I accidently forgot to remove the "More" damage line when copying the stat from the previous stat

Co-authored-by: LocalIdentity <localidentity2@gmail.com>
2022-12-19 22:32:30 +11:00
QuickStick
bb6cd190e1 Fix minion specific mod no longer apply to specific minion (#5394) 2022-12-18 22:40:31 +11:00
Andrew B
908a30ebb0 Add rotting legion missing zombie mod (#5385) 2022-12-17 15:22:28 +11:00