Fix npm install dependency resolution issues #3

2025-11-21T12:54:45+01:00

overspend1 commented

2025-11-21 12:54:45 +01:00

(Migrated from github.com)

Backend fix:

Add python3-dev to build dependencies for psutil compilation
psutil requires Python development headers to build C extensions

Frontend fix:

Explicitly copy package-lock.json to ensure it's available for npm ci
Add verification step to confirm package-lock.json exists before npm ci
Prevents "npm ci" usage errors due to missing lock file

Summary by CodeRabbit

Chores
- Enhanced build process reliability through improved dependency verification
- Updated build configuration to ensure consistent package management and environment setup

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Backend fix: - Add python3-dev to build dependencies for psutil compilation - psutil requires Python development headers to build C extensions Frontend fix: - Explicitly copy package-lock.json to ensure it's available for npm ci - Add verification step to confirm package-lock.json exists before npm ci - Prevents "npm ci" usage errors due to missing lock file  ## Summary by CodeRabbit * **Chores** * Enhanced build process reliability through improved dependency verification * Updated build configuration to ensure consistent package management and environment setup ✏️ Tip: You can customize this high-level summary in your review settings.

coderabbitai[bot] commented

2025-11-21 12:54:53 +01:00

(Migrated from github.com)

Caution

Review failed

The pull request is closed.

Walkthrough

Two Dockerfile modifications: the backend stage adds python3-dev to dependencies for building Python packages, while the frontend stage changes package file copying from wildcard pattern to explicit filenames and adds a file existence check before running npm ci.

Changes

Cohort / File(s)	Summary
Backend build dependencies `backend/Dockerfile`	Added `python3-dev` to builder stage `apt-get install` command; updated comment to reference building Python packages
Frontend package verification and installation `frontend/Dockerfile`	Changed package file copy from `package*.json` wildcard to explicit `package.json package-lock.json`; added existence check `test -f package-lock.json` before running `npm ci`; updated comment to reflect verification step

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Straightforward dependency addition in backend Dockerfile
Explicit file copying replaces wildcard pattern with defensive file existence check in frontend Dockerfile

Poem

🐰 A builder stage grows strong with dev tools so fine,
Package-lock verified before install time,
No wildcards needed—explicit paths we choose,
With Python headers and npm checks, we can't lose! 📦✨

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch claude/fix-npm-install-01PgzBPg7kQLEAFNGdtDe5fY

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fd904ab547 and 8f83bacdb9.

📒 Files selected for processing (2)

backend/Dockerfile (1 hunks)
frontend/Dockerfile (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

> [!CAUTION] > ## Review failed > > The pull request is closed.   ## Walkthrough Two Dockerfile modifications: the backend stage adds `python3-dev` to dependencies for building Python packages, while the frontend stage changes package file copying from wildcard pattern to explicit filenames and adds a file existence check before running `npm ci`. ## Changes | Cohort / File(s) | Summary | |---|---| | **Backend build dependencies** `backend/Dockerfile` | Added `python3-dev` to builder stage `apt-get install` command; updated comment to reference building Python packages | | **Frontend package verification and installation** `frontend/Dockerfile` | Changed package file copy from `package*.json` wildcard to explicit `package.json package-lock.json`; added existence check `test -f package-lock.json` before running `npm ci`; updated comment to reflect verification step | ## Estimated code review effort 🎯 2 (Simple) | ⏱️ ~8 minutes - Straightforward dependency addition in backend Dockerfile - Explicit file copying replaces wildcard pattern with defensive file existence check in frontend Dockerfile ## Poem > 🐰 A builder stage grows strong with dev tools so fine, > Package-lock verified before install time, > No wildcards needed—explicit paths we choose, > With Python headers and npm checks, we can't lose! 📦✨   <details> <summary>✨ Finishing touches</summary> <details> <summary>🧪 Generate unit tests (beta)</summary> - [ ]  Create PR with unit tests - [ ]  Post copyable unit tests in a comment - [ ]  Commit unit tests in branch `claude/fix-npm-install-01PgzBPg7kQLEAFNGdtDe5fY` </details> </details>  --- <details> <summary>📜 Recent review details</summary> **Configuration used**: CodeRabbit UI **Review profile**: CHILL **Plan**: Pro <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between fd904ab547f510fe42c8d476feda8edf20253c18 and 8f83bacdb942a52a6afffcc88a05488c7f3b6e98. </details> <details> <summary>📒 Files selected for processing (2)</summary> * `backend/Dockerfile` (1 hunks) * `frontend/Dockerfile` (1 hunks) </details> </details>  --- Thanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=overspend1/bot-dashboard&utm_content=3)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. <details> <summary>❤️ Share</summary> - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code) </details> Comment `@coderabbitai help` to get the list of available commands and usage tips.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: overspend1/bot-dashboard#3