* fix: enable Unicode separators and caret motions
As the runtime is going to support Unicode installation locations and
build directories, some UTF-8 text is going to reach the Lua side of
the project. This includes the script path, the user path, any paths
yielded from file searches and also imported character names from
accounts.
Care needs to be taken in many places where string operations are
performed as no longer does a byte necessarily correspond to a single
character and anything that truncates, reverses or otherwise slices
strings could need an audit.
This change fixes cursor movement in `EditControl`s with the arrow keys
as those historically used string matching and byte offsets. It also
ensures that the use of arbitrary Unicode codepoints as decimal and
thousands separators works correctly as the previous code used unaware
reversing and slicing.
* fix: turn update paths relative for wide installs
The updater is a fixed piece of older code that uses a Lua runtime that
only handles paths that are representable in the user's text codepage.
As the software may be installed in a location that cannot be expressed
in that way, to mitigate the problem we turn all the paths in the
update op-files into relative paths. That way as long as we never use
exotic codepoints in our own paths it should be able to apply them
cleanly and restart Path of Building afterward with a relative path.
The updater executable can ironically enough not be updated at all with
the related type of runtime hacks we introduced in SimpleGraphic as the
updater deadlocks in updating itself. We have to work around its
shortcomings in how we produce the op-files and possibly the update
application script that runs under that limited runtime.
* fix: convert GIFs masquerading as PNG to PNG
Upon removing support for several file formats like GIF and BLP from the
SimpleGraphic runtime, we noticed that there were some assets that had
incorrect file extensions and loaded only thanks to file format
detection ignoring extensions.
As the actual file format loader for GIF was removed, these stealth GIFs
are now losslessly converted to PNG.
* Add luautf8 to Dockerfile
---------
Co-authored-by: Wires77 <Wires77@users.noreply.github.com>
Changes the exporter to use the new datc64 files and the regular dat64 files be be deprecated at some point
Fixes the spec for a number of tables that were changed to use the new UInt16 type
* fix: allow account names with dashed in them to be imported correctly
* move ReplaceCharAtIndex to Common.lua and fix indent
* Simplify logic
---------
Co-authored-by: Clemens Himmer <clemens@himmer.software>
Co-authored-by: Wires77 <Wires77@users.noreply.github.com>
* fix issue #8259 - rupture applying multiple times
* add changes to sup_dex.txt as well
---------
Co-authored-by: majochem <majochem@users.noreply.github.com>
Kalandra's touch ignored item overrides causing the tooltip to only show
stat difference when unequipping the copied ring.
During filtering of mods an iterator was modified causing some mods to
be skipped.
* FIX: Blasphemy auras triggering mana cost warning
The warning calculations did not consdier the case of a skill having
both reservation and mana costs. Mana cost would be checked after applying
reservation and not before causing the warning to show up in some cases.
This pr adds a check and handling for such cases, as well as using the
warnings from output to determine color override for cost labels instead
of re-checking pool availability.
* Update Calcs.lua
---------
Co-authored-by: LocalIdentity <31035929+LocalIdentity@users.noreply.github.com>
* fix Import With Discriminators
* make it use `#` instead of `-`
* update to only gsub on page downloads, and fix account name dropdown
* fix saved value
* cleanup extra gsub
* sort all bases and fix trapsetter gloves
* update to new bases
* fix newlines
* Add support for exporting bases
* update mods on bases and add some new items
* FIX: numerous fullDPS issues
* FIX: output reuse and acceleration without existing env
* FIX: prevent calculation of fullDPS if it's not needed for item sorting