Commit Graph

3515 Commits

Author SHA1 Message Date
Lars Viklund
be184b3076 Fix fallout from SimpleGraphic upgrade with wider Unicode support (#8412)
* fix: enable Unicode separators and caret motions

As the runtime is going to support Unicode installation locations and
build directories, some UTF-8 text is going to reach the Lua side of
the project. This includes the script path, the user path, any paths
yielded from file searches and also imported character names from
accounts.

Care needs to be taken in many places where string operations are
performed as no longer does a byte necessarily correspond to a single
character and anything that truncates, reverses or otherwise slices
strings could need an audit.

This change fixes cursor movement in `EditControl`s with the arrow keys
as those historically used string matching and byte offsets. It also
ensures that the use of arbitrary Unicode codepoints as decimal and
thousands separators works correctly as the previous code used unaware
reversing and slicing.

* fix: turn update paths relative for wide installs

The updater is a fixed piece of older code that uses a Lua runtime that
only handles paths that are representable in the user's text codepage.

As the software may be installed in a location that cannot be expressed
in that way, to mitigate the problem we turn all the paths in the
update op-files into relative paths. That way as long as we never use
exotic codepoints in our own paths it should be able to apply them
cleanly and restart Path of Building afterward with a relative path.

The updater executable can ironically enough not be updated at all with
the related type of runtime hacks we introduced in SimpleGraphic as the
updater deadlocks in updating itself. We have to work around its
shortcomings in how we produce the op-files and possibly the update
application script that runs under that limited runtime.

* fix: convert GIFs masquerading as PNG to PNG

Upon removing support for several file formats like GIF and BLP from the
SimpleGraphic runtime, we noticed that there were some assets that had
incorrect file extensions and loaded only thanks to file format
detection ignoring extensions.

As the actual file format loader for GIF was removed, these stealth GIFs
are now losslessly converted to PNG.

* Add luautf8 to Dockerfile

---------

Co-authored-by: Wires77 <Wires77@users.noreply.github.com>
2025-01-28 19:01:01 -06:00
Wires77
009262ef6a Restore plus sign for Tavukai
Fixes #8422
2025-01-21 09:12:36 -06:00
Paliak
fc311a782c FEAT!: implements lua side hotkey for screenshots (#8414)
Changes the hotkey from just prints screen to control print screen to
prevent potential conflicts with other screenshot programs.
2025-01-20 05:41:43 +11:00
Chuanhsing
732a169c01 Add poedb.tw to import website list (#8401) 2025-01-19 01:12:53 -06:00
Paliak
03c273be1b FIX(mods): GemProperty mod not being affected by scaling (#8409) 2025-01-19 03:59:15 +11:00
LocalIdentity
beae00c81b Update stat requirement formula 2025-01-19 01:13:14 +11:00
Wires77
c38dd2b8ec Fix unparsed item text "Block chance" 2025-01-16 21:49:26 -06:00
Paliak
d3ae425072 FIX(fulldps): propagate overrides from inside of initEnv (#8392) 2025-01-14 21:45:51 +11:00
LocalIdentity
42cb754429 Remove statOrderKey 2025-01-14 21:43:34 +11:00
Никита Троянов
76a97afd30 fix #8388 (#8390) 2025-01-11 20:26:11 +11:00
Nighty
531e8ecdce fix caps/spelling/space (#8371)
EHPsurvivalTime -> EHPSurvivalTime
atleast -> at least
delete random space
2025-01-03 16:20:36 -06:00
LocalIdentity
5f2af00520 Use new datc64 files for export
Changes the exporter to use the new datc64 files and the regular dat64 files be be deprecated at some point
Fixes the spec for a number of tables that were changed to use the new UInt16 type
2024-12-01 13:55:40 +11:00
LocalIdentity
3af97060be Update query mods 2024-11-24 16:32:40 +11:00
LocalIdentity
4c9f8de18e Fix export scripts
latest updated add a row to Mods.dat which has no ModFamily entry
2024-11-24 16:30:49 +11:00
Regisle
80dfb6f56b remove url encoding check, as it was broken (#8372) 2024-11-21 23:52:47 -06:00
Clemens Himmer
26a80ef52b fix: allow account names with dashed in them to be imported correctly (#8370)
* fix: allow account names with dashed in them to be imported correctly

* move ReplaceCharAtIndex to Common.lua and fix indent

* Simplify logic

---------

Co-authored-by: Clemens Himmer <clemens@himmer.software>
Co-authored-by: Wires77 <Wires77@users.noreply.github.com>
2024-11-21 23:16:46 -06:00
Regisle
123d8ffda8 filter for only poe1 realms and fix sorting (#8367) 2024-11-19 22:26:53 +11:00
Regisle
1d0772aa86 Add discriminator check to account import (#8366)
* add Discriminator To Account Debug Steps

* add preventative measures and extra warnings

* 1234 instead of 0000
2024-11-19 16:51:47 +11:00
Túlio Campos
a744dfe26f fix: allow xbox and sony realms characters import (#8365) 2024-11-19 05:22:42 +11:00
LocalIdentity
14a61e262f Fix exporter
Add new datatype UInt16
Removed old dats
Manually code in SkillTotem loop
Update spec
2024-11-18 21:51:49 +11:00
majochem
76756fff7a Fix Rupture sometimes applying multiple times (#8320)
* fix issue #8259 - rupture applying multiple times

* add changes to sup_dex.txt as well

---------

Co-authored-by: majochem <majochem@users.noreply.github.com>
2024-11-18 17:00:48 +11:00
Paliak
7da21f6c8e FIX: kalandra's touch stat copying (#8323)
Kalandra's touch ignored item overrides causing the tooltip to only show
stat difference when unequipping the copied ring.

During filtering of mods an iterator was modified causing some mods to
be skipped.
2024-11-18 16:59:47 +11:00
Paliak
086c8ed2f9 Fix blasphemy auras triggering mana cost warning (#8324)
* FIX: Blasphemy auras triggering mana cost warning

The warning calculations did not consdier the case of a skill having
both reservation and mana costs. Mana cost would be checked after applying
reservation and not before causing the warning to show up in some cases.

This pr adds a check and handling for such cases, as well as using the
warnings from output to determine color override for cost labels instead
of re-checking pool availability.

* Update Calcs.lua

---------

Co-authored-by: LocalIdentity <31035929+LocalIdentity@users.noreply.github.com>
2024-11-18 16:58:41 +11:00
Jonathan Dang
239aeb2643 Added Changes (#8330)
Calculations fixed, mod inc display edge case issue.
2024-11-18 16:55:19 +11:00
Jonathan Dang
e20bb1b8f3 Fixed Empty actor item detection (#8331)
Changed independent IF statements in CalcPerform into single if-elseif statement.
2024-11-18 16:52:35 +11:00
Paliak
f88e4345cc FIX: special characters in set name causing crash (#8353)
Makes loadout matching logic use plain text pattern finding to allow use of reserved characters in set names.
2024-11-18 16:51:41 +11:00
Regisle
bd766834f0 Fix Warden Import Colour (#8362) 2024-11-18 16:51:19 +11:00
Regisle
3a0e067685 Fix import with discriminators (#8361)
* fix Import With Discriminators

* make it use `#` instead of `-`

* update to only gsub on page downloads, and fix account name dropdown

* fix saved value

* cleanup extra gsub
2024-11-17 23:38:27 -06:00
Regisle
78b52c95ec Vengeful Cry Improvements (#8303)
* Vengeful Cry Improvements

* remove disable by default
2024-10-20 21:10:12 +11:00
Regisle
fb447c59ae Hollow Palm Technique proper Dual Wielding (#8307) 2024-10-20 20:58:59 +11:00
0xjc
8cfe3052f2 Improve EHP overkill approximation, especially for MoM (#7568) 2024-10-20 20:58:44 +11:00
Connor Thelin
22d8b27e5a Implement Enemy Damage Type defaulting to "Average" after user swaps off of a Boss Skill Preset other than None. (#8318) 2024-10-20 20:58:16 +11:00
Regisle
921aba3df8 Fix abyss socket items with no selectableSocketCount (eg Wraithlord) (#8317) 2024-10-20 20:55:50 +11:00
Regisle
c1904dfcef Move build display stats to its own file (#8337)
* Move build display stats to its own file

* add comments

* fix merge issue
2024-10-20 20:54:06 +11:00
Paliak
795ad13d76 FEAT(warnings): add name of source causing requirements warning to warning message (#8335) 2024-10-20 20:46:05 +11:00
LocalIdentity
4f2291a089 Export from game files 2024-10-20 20:29:32 +11:00
Nighty
f6d095a527 Fix Advanced Item Description error popup problems (#8311)
* show as warning, once per session

* move to keypress handling code
2024-09-27 00:56:07 +10:00
Regisle
8369b448f6 fix PartyTab Crash with thresholds (#8314) 2024-09-22 17:16:45 +10:00
Regisle
494718f8e0 fix party tab warcries clearing links instead of warcries (#8313) 2024-09-22 15:57:39 +10:00
Regisle
33da7155b2 Update rare templates (#8229)
* sort all bases and fix trapsetter gloves

* update to new bases

* fix newlines

* Add support for exporting bases

* update mods on bases and add some new items
2024-09-20 14:29:55 +10:00
Paliak
118e0b402e Fix numerous fullDPS tooltip issues (#8247)
* FIX: numerous fullDPS issues

* FIX: output reuse and acceleration without existing env

* FIX: prevent calculation of fullDPS if it's not needed for item sorting
2024-09-20 14:28:01 +10:00
Regisle
03d0d31c92 Shock and scorch fixes (#8272)
* fix max stacks

* fix calcs tab value and lightning conduit etc
2024-09-20 14:27:05 +10:00
Regisle
6363a9fa39 Fix Trade Query Stat Weight Crash (#8278)
* Fix Trade Query Stat Weight Crash

* Update TradeQuery.lua

---------

Co-authored-by: LocalIdentity <31035929+LocalIdentity@users.noreply.github.com>
2024-09-20 14:26:29 +10:00
Regisle
02576305ae Fixed Cluster notable cap (#8280)
* add back weight multiplier keys

* add weight key for large clusters
2024-09-20 14:24:58 +10:00
OriginalThing
717b698259 Fix 3.1 xp multiplier calc for levels 95-99 (#8283)
* fix 3.1 xp multiplier calc for levels 95-99

* corrected lvl 97 multplier
2024-09-20 14:23:15 +10:00
Nighty
f4df5de831 Add Ctrl+Alt+c error popup (#8287) 2024-09-20 14:19:50 +10:00
Regisle
d34137a440 fix Ghost Reaver and Brutal Fervour Interaction (#8290) 2024-09-20 14:18:55 +10:00
Tomas Slusny
5f3d097fc4 Remove non-existant stat from Cadigan's Crown (#8294)
Im not sure how this got there:

Nearby Enemies cannot deal Critical Strikes

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
2024-09-20 14:18:35 +10:00
Regisle
c7ae7eee95 Fix Dual Strike of Ambidexterity and Cleave of Rage (#8304)
* Fix Dual Strike of Ambidexterity and Cleave of Rage

* fix whitespace
2024-09-20 14:17:10 +10:00
Regisle
aef7a7ef45 Change config types to count allow zero (#8305) 2024-09-20 14:15:29 +10:00