f858c6c537
This commit updates the secondary (inner deadzone) and tertiary (max
ball landing distance) radii for the Molten Strike skill. It also
overhauls most of the breakdown display for the tertiary radius. The
new calculations are based on the derivation from the standalone
Molten Strike DPS Calculator (same author as this commit). Look for
the maxBallLandingDist variable here for details:
https://gitlab.com/MoldyDwarf/MoltenStrikeDPS/-/blob/master/moltenstrike.html
Notable math changes:
- Projectile speed modifies the distance traveled, not the landing
area (making it basically a multiplier on radius, not on
area). It's easy to verify this with swapping faster vs. slower
projectiles in Haku's hideout and seeing how many tiles away the
balls land under the two conditions.
- The inner deadzone radius ("secondary radius" in PoB) cannot be
modified in any way. This makes all of the tertiary radius
calculations slightly trickier. See the aforementioned external
calculator link for more details.
Notable functions added or changed:
- calcMoltenStrikeTertiaryRadius (new): actual calculation, including
rounding (but using a simple assumption about how rounding is done
for the skill)
- setMoltenStrikeTertiaryRadiusBreakdown (new): does all the
calculating and rendering of the breakdown display for the tertiary
radius. We do both in the same place because we compute and display
so many intermediate values.
- calcs.offence (modified): now calls the two functions above when
skillData.projectileSpeedAppliesToMSAreaOfEffect exists, instead of
inlining some math that wasn't quite correct. Also, disables the
breakpoint calculations for the secondary radius for Molten Strike
since no mods affect that radius.
Also:
- Moved the label to the top of breakdown.area display for better
readability and to be more consistent with other breakdowns.
- Allow devs to put vscode workspace config files inside the repo
directory.
Future work:
- The external calculator will be simplified after these changes are
released to the community. Many of its form elements will be
replaced by having users just type in the skill-specific stats from
PoB.
- If we're ever able to reliably datamine boss radii, then the DPS
calculations from the external calculator could be integrated into
PoB. If that ever happens, the external calculator will be retired.
26 lines
291 B
Plaintext
26 lines
291 B
Plaintext
# Development tools
|
|
.idea/
|
|
.vs/
|
|
.vscode/
|
|
*.code-workspace
|
|
|
|
# Development files
|
|
*.lnk
|
|
|
|
# Application files
|
|
Builds/
|
|
*.cfg
|
|
Settings.xml
|
|
|
|
# Testing
|
|
luajit/
|
|
|
|
# Release
|
|
manifest-updated.xml
|
|
|
|
# GGPK Export
|
|
src/Export/ggpk/Metadata/
|
|
src/Export/ggpk/Data/
|
|
src/Export/ggpk/*.exe
|
|
src/Export/ggpk/*.dll
|