Commit Graph

201 Commits

Author SHA1 Message Date
talkmill
19c6bc3d5c unreserved life colorCodes.NEGATIVE at 0 (#4618) 2022-07-25 05:09:44 +10:00
Nightblade
f41925184e fix spelling in Build.lua (#4621)
* Update Build.lua

ascendencies -> ascendancies

* Update Build.lua

catched -> caught

* Update Build.lua

highestAtrribute -> highestAttribute
2022-07-25 05:07:23 +10:00
Nightblade
e77e56b192 remove unnecessary (and broken) code (#4620) 2022-07-25 05:07:01 +10:00
Lothrik (MaXiMiUS)
7fcc82a70b Prevent invalid character level values (#4609) 2022-07-17 15:55:44 +10:00
LocalIdentity
dc8bff7ea5 Timeless Jewel implementation (#4527)
* WIP: start of Timeless Jewel implementation

* QoL minor edit

* Feat: add auto-addition of timeless stats to Notables for 'add' case

* Feat: added Militant Faith; made additions to Notables on separate line

* Feat: Add Elegant Hubris, add support for 'replace'

* Fix: remove a print; add a print

* Fix: added change recommendations from Lothrik

* Fix: fix things that broke in last commit

* fix correct file (#11)

* Fix Militant Faith

* Remove all remaining editedNode logic and add timeless jewel search UI (#12)

* Remove all remaining editedNode logic
* Initial pass on timeless jewel search UI
* Update TreeTab.lua

* move handling of result out of read function

* swap to using numerical IDs and move seed range check

* fix issues

* Glorious Vanity

* WIP: GV stuff

* WIP: more GV processing fixes

* WIP: more fixes

* Fix: reading the GV file fully

* Fix: Glorious Vanity timeless implemenation - still need to set roll values

* Second pass on Timeless Jewel search UI (#15)

* add handling of small and might_legacy of the vaal

* add stats to might and legacy of the vaal

* add bias to better determine node type

* add stat ranges for might and legacy of the vaal

* Implement timeless jewel search function (#16)

* Implement timeless jewel search function

* remove no-op as its unused now

* Update to use 1 NodeIndex file

* fix additions conflict

* jewel data conflict

* Move Glorious Vanity to zip file

* Fix Elegant Hubris seeds in jewel search tool (#4528)

* Fix integer Glorious Vanity notables, load LUTs from compressed files (#4536)

* Inflate/Deflate LUTs

* Fixed integer Glorious Vanity notables

* move stuff to helper function and add support for "g" format mods

* Fixed loading of compressed GV timeless jewel

* Add generated .zip files

* defer table creation of specific nodes until that node is read

* cleanup

* Code cleanup

* Implement logic to load from binary file by default, and to decompress and create it from .zip if it doesn't exist

Co-authored-by: Regisle <Regisle.godform@gmail.com>

* Further timeless jewel search improvements (#4529)

* Inflate/Deflate LUTs

* Further timeless jewel search improvements

.. including a passive tree view for socket locations and visual feedback when timeless jewels are added to the build.

* Hide socketViewer if hovering over jewelType dropdown

* Update TreeTab.lua

* Add conqueror selection dropdown menu

* Update TreeTab.lua

* Add node weights to timeless jewel search

* Fixed integer Glorious Vanity notables

* Add "required" node weight option, improve formatting

* Add small mod searching (Glorious Vanity)

* move stuff to helper function and add support for "g" format mods

* Swap weight slider and search dropdown positions

* Fixed loading of compressed GV timeless jewel

* Add generated .zip files

* Fix Glorious Vanity small node processing

* Update TreeTab.lua

* Improve search result output formatting

* Automatically determine nearby socket keystones

* Exit loop earlier to avoid wasting time

* Update TreeTab.lua

* Update TreeTab.lua

* defer table creation of specific nodes until that node is read

* cleanup

* Add detailed node breakdown to tooltips

* Code cleanup

* Update node breakdown to display actual stats

* Make most timeless search UI settings persistent

* Fix bug where node tooltip results were culled

* Erase desired node input on jewel type change

* Remove unused Might/Legacy of the Vaal code

* Make "required" nodes actually required

* Update TreeTab.lua

* optimise search function and show total weight in first column

* Code clean up

* Remove unused variables

* Update TreeTab.lua

* Fix Glorious Vanity node filtering

* Standardize search result number formatting

.. and hide search result tooltips when hovering over node selection dropdown.

* Add secondary node weight slider for GV

* Update TreeTab.lua

* Default to 0 for missing nodeWeights instead of 0.1

* Revert last commit + enable second nodeSlider for non-GV jewels

* Update TimelessJewelListControl.lua

* Fix broken node weights with a fairly big rewrite

* Swap nodeWeight/nodeWeight2 back...

* Fix timeless jewel node filtering typo

* Implement logic to load from binary file by default, and to decompress and create it from .zip if it doesn't exist

Co-authored-by: Wires77 <Wires77@users.noreply.github.com>
Co-authored-by: Regisle <Regisle.godform@gmail.com>

* Further Timeless Jewel search improvements (#4546)

* Fix broken might/legacy of the vaal + misc cleanup

* Update to new noTooltip draw behavior

* Update edit box when slider values change

.. and prevent duplicate nodes from being added to edit box.

* Remove search result total weight column

* Fix dynamic slider update bug

* Sanitize user input and fix a few errors

* Wipe all search input on reset

* Fix another missed variable sync

* Rebuild searchListTbl from timelessData.searchList

* Save timeless jewel search config to build XML

* Update TreeTab.lua

* Fixed swapped weight values, minor refactors

* Fix search list result updating

* Fix statMod2 nil error on small nodes

* Properly handle replace and add types, finally

* Minor consistency edit

* Remove dynamic slider width code

* Set modFlag to prompt build saving on several ..

.. different events, including:
- timelessData.searchList change (node weight sliders)
- updateSearchList called
- conqueror change
- jewel socket change
- desired node change (direct and via dropdown list)

* Remove lingering duplicate variable from old implementation

* Save socketFilter state to build XML

* Change tooltip colour for tree node names

Co-authored-by: Wires77 <Wires77@users.noreply.github.com>
Co-authored-by: LocalIdentity <localidentity2@gmail.com>

Co-authored-by: Nostrademous <nostrademous@hotmail.com>
Co-authored-by: Regisle <49933620+Regisle@users.noreply.github.com>
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Co-authored-by: Lothrik (MaXiMiUS) <maximius@gmail.com>
Co-authored-by: Regisle <Regisle.godform@gmail.com>
Co-authored-by: Wires77 <Wires77@users.noreply.github.com>
2022-07-11 16:03:18 +10:00
TPlant
5750d0f28b Fix overlapping tooltips, move bandit and pantheon options into the Config tab (#4441)
* Fix multiple tooltips being displayed at the same time

* Move bandit and pantheon controls to the config tab
2022-07-09 18:08:16 -05:00
Nightblade
5301046476 put move speed below resists in side-bar (#4426)
Its current position between "phys dmg reduction" and "spell suppression" seems a bit odd, and resists are probably higher priority.
2022-07-03 07:02:26 +10:00
Tomas Slusny
42a6412039 Split max hit display (and colorize it) in sidebar (#4371)
* Split max hit display (and colorize it) in sidebar

The second max hit taken was a bit questionable metric to display
as it do not really means anything. Thanks to this the tooltips also
were unable to display increases to specific max hit (for example taking
survivalist etc).

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>

* Automatically merge elemental max hits into one if they are identical

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
2022-06-03 00:32:56 -05:00
Regisle
89848f852c Minor EHP improvments (#4227)
* minor improvements to defences

* update helper function

* add option to disable gain on block

* fix spelling mistake

* apply chill to enemy

* fix disable gain on block

* basic support for enemy crit


basic support for enemy crit

* correctly apply speedup maxhit limit

* Fix issue with enemy crit incorrectly being added to 1 twice

* Fix "defend with X% armour" calcs

* esbypass on block

* Cap portionArmour at 100%

For fairly obvious reasons, armour cannot mitigate more than 100% of incoming damage. Also removed an unnecessary NaN check as I cannot get the error it was intended to prevent to trigger under any conditions.

* enemy pen applying when it shouldnt

* apply energyshield recoverable correctly

* fix spelling mistake and max depth value of ehp helper function

* fix armour reduction displays and breakdowns

* Update CalcDefence.lua

* Factor in resistances and flat reduction

.. and explain what's happening briefly in the related tooltip.

* Update CalcDefence.lua

* Update CalcDefence.lua

* Remove obsolete variable reference

* fix armour reduction breakdowns to make more sense

* Fix incorrect PDR calc

* Restore PDR cap

* Add some sanity checks

This prevents nonsensical (negative) damage values and properly handles negative penetration.

* fix merge issue


fix merge issue

* fix gain when hit when speedup happens

* fix wrong damage category for projectile spells

Co-authored-by: Lothrik <maximius@gmail.com>
2022-06-03 00:12:16 -05:00
Wires77
e484fb2898 Fix Pantheon dropdown interacting with elements behind list (#4377)
* Remove tooltip if covering dropdown is opened

* Fix tooltip when hovering over major gods

* Fix pantheon tooltip overlap

* Remove unnecessary function

Co-authored-by: LocalIdentity <localidentity2@gmail.com>
2022-06-02 15:58:42 +10:00
Wires77
7164226505 Fix crash when loading build containing a newer tree (#4386) 2022-06-02 12:13:15 +10:00
Tomas Slusny
283ce831f8 Remove import popup and allow both code and URLs in import (#4294)
With import type autodetection the popup is no longer necessary and this
can be done in a lot more elegant way.

Supersedes #4246
Fixes #4163

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
2022-05-28 01:12:53 -05:00
BuildTools
1679a8a1a8 Added keyboard shortcut for Notes section "Ctrl+6" 2022-04-18 12:01:00 -04:00
Solofme
1306820291 Add support for Holy Relic Nova triggering (#4051)
* Enable holy relic nova trigger calculations

* Bugfix for non-minion trigger skills

* Revert changes to minion.lua since it is auto-generated.

* Spacing

* Fix minion vs. player cooldown override

* Remove Ugly Hack as per Nostrademous' suggestion

Co-authored-by: LocalIdentity <31035929+LocalIdentity@users.noreply.github.com>
2022-02-12 04:32:16 +11:00
Wires77
52272153f1 Merge pull request #4105 from PathOfBuildingCommunity/add_sidebar+calcs+configs
Add colours to the sidebar, config page, and calcs page
2022-02-11 01:12:10 -06:00
LocalIdentity
16f7d69f49 Adds colours to the sidebar + configs page + calcs page
Add colours for Life, Mana, Energy Shield, elemental ailments, Rage, Ward, Evasion, and damage types
Colours are on the Configs page in tooltips and on the display text
Add colours to the Calcs page for skill damage elements and in the eHP breakdown for each element
Add colours to the sidebar
2022-02-08 23:42:55 +11:00
Nightblade
1a56d845bf Add option to hide Warnings
fixes #4080
2022-02-06 21:11:00 +11:00
Wires77
6eec032ddf Merge remote-tracking branch 'fork/dev' into add-requested-spectres 2022-02-04 00:35:15 -06:00
Wires77
0f8ac1c01c Merge branch 'dev' into CalcDefencesRework 2022-02-03 19:23:56 -06:00
Wires77
8280691a2f Merge branch 'dev' into omniscience 2022-02-03 18:58:14 -06:00
Lothrik
4b0e56aa87 Add brief spectre buff/curse documentation 2022-02-03 05:50:16 -08:00
Nostrademous
70cf0f6fdb feat: Put FullDPS breakdown into XML Build Save file (#4018) 2022-02-03 21:26:29 +11:00
Nostrademous
84aa26f070 Fix: SkillPart Stage DropDown (#4029)
* fix: add stages to skills that need them and have multi-parts

* fix: add stages to Penance Brand

* fix: fixed max sustained blight stack to have -1 again

* Add stages for Scourge Arrow and Death Wish

* fix: add ActionSpeed modifier support; fix Scorching Ray to use actual castTime

Co-authored-by: LocalIdentity <localidentity2@gmail.com>
2022-02-03 21:11:05 +11:00
Lexy
bf42da9067 Properly handle attribute requirements on items/gems 2022-02-01 18:54:26 +01:00
Wires77
8600af403c Merge branch 'dev' into omniscience 2022-01-30 00:42:25 -06:00
JonAloof
06381e74c2 Remove extra line 2022-01-26 19:07:09 -08:00
JonAloof
8e99b4da0e Updated dropbox to auto-resize 2022-01-26 18:55:59 -08:00
JonAloof
45e10fe444 Updated Kraityn's passive attributes based on 3.16 2022-01-26 17:32:40 -08:00
Regisle
6024cee959 implement "ward does not break during flask effect" 2022-01-26 23:03:36 +10:30
Regisle
80b7e4460f further improvements and bugfixes
mainly added block/avoid section and added breakdowns
2022-01-24 17:38:33 +10:30
Lexy
0871e06b04 Wrapup omniscience implementation 2022-01-22 21:17:15 +01:00
Lexy
6773808692 add support for omniscience (no proper attributes calculation yet) 2022-01-22 18:46:16 +01:00
Wires77
28217b385a Merge pull request #3902 from Nostrademous/SaveXMLFixes
fix: Fixes #3155 - remove duplicate and not pertinent values being saved in XML
2022-01-21 10:08:23 -06:00
Trevor Lund
210c6eb98c Merge pull request #3896 from Lothrik/add-brand-attachment-range
Add full support for brand attachment range
2022-01-21 01:40:27 -06:00
Nostrademous
b5342d5b5f fix: remove duplicate and not pertinent values being saved in XML 2022-01-17 13:58:42 -05:00
Lothrik
745158c301 Add full brand attachment range support
Adds full support for brand attachment range to the calcs breakdown, skill sidebar, and node/item comparisons.
2022-01-15 00:04:56 -08:00
Trevor Lund
b8b4d7052f Merge pull request #3836 from KillerMZE/warnings
Add warnings when the build is impossible in-game
2022-01-13 20:44:38 -06:00
Trevor Lund
e48f6da695 Merge pull request #3865 from PathOfBuildingCommunity/fix_cooldown-display-accuracy
Change skill cooldown to display in milliseconds
2022-01-11 02:08:23 -06:00
Wires77
39f68f9a80 cleanup: simplify warning functions 2022-01-11 01:30:59 -06:00
Trevor Lund
da734f9906 Merge branch 'dev' into warnings 2022-01-11 01:18:29 -06:00
Trevor Lund
87980238cf Merge pull request #3663 from PJacek/new-costs
Fixes #3661 - Add support for ongoing costs
2022-01-10 23:58:43 -06:00
Trevor Lund
4d51cc6b16 Merge pull request #3726 from pHiney/dropdown_auto_width
Dropdown auto width
2022-01-10 23:34:25 -06:00
LocalIdentity
4d2df07f93 Remove tab 2022-01-07 10:27:58 +11:00
Nostrademous
92bafae1dd feat: Enable stages for multi-part skills at a per-part level (#3859)
* feat: Enable stages for multi-part skills at a per-part level

* feat: enhanced Vaal Flameblast to use stages

* fix: updated DPS calculation for Blade Flurry to use preDamageFunc

* fix: spacing

* fix: DPS equation; naming

* fix: implemented updated DPS calculation

* feat & fix: made multi-stage and multi-part and multi-stage skills be able to specify a minimum stage to start at

* fix: forward fix for multi-stack on release
2022-01-07 09:06:39 +11:00
Hiney
6f4f1a2043 Add Ctrl-I for import (#3813) 2022-01-04 11:36:11 +11:00
LocalIdentity
8db436fe3c Change skill cooldown to display in milliseconds
The game runs on milliseconds so we should update the display in PoB to be the same
Also fixes trap cooldown to round up to nearest server tick
2022-01-04 10:08:47 +11:00
Eyal
cdd3b086fb Added warnings 2021-12-10 03:38:32 +02:00
Hiney
5584030dd8 Add more DropDownControls 2021-11-05 20:38:56 +11:00
Hiney
23f4cb84bc Changed a few to auto drop wide, but having trouble with item sort and it's scrollbar 2021-11-04 00:03:07 +11:00
PJacek
801fd5d24f Add support for ongoing costs 2021-10-29 14:11:08 +02:00