* fix: import logic for vaal gems
* fix: ensure gemId exists before gsub
* fix: add baseTypeName to exported active skills and gems
* fix: update gem lookup table and gem names for vaal gems
* fix: minor optimisation when adding to the gemForBaseName lookup table
* fix: update name for secondary effect skills
* New save format
Uses the Path of Exile BaseItemType.Id for the gem in gemId (as it always has been).
The skillId attribute is also kept and maps to the gems variant primary GrantedEffect.Id.
Adds a new attribute called variantId that maps to the variant of the game, eg. Arc, ArcAltX, or ArcAltY. This is to help identify which variant is used rather than relying on every gem variant having its own unique granted effect.
For the majority of gems skillId and variantId are the same, but it is not true for every case.
* Remove redundant nil check
* WIP
* WIP 2
* WIP 3
* WIP 4
* Add stated transfigs
* fix minion parsing
* remove a print out
* extra tests for stuff
* implement when more stat sets than skill levels exist
* fix using wrong player level req
* added transfigured gems through GemEffects.DAT row #65
* added transfigured gems through GemEffects.DAT row #140
* added transfigured gems through GemEffects.DAT row #275
* added transfigured gems through GemEffects.DAT row #500
* added transfigured gems through GemEffects.DAT row #564
* fix \n in active gem descriptions
* Added gems from lines 564-623 (#21)
* added transfigured gems through GemEffects.DAT row #868 - END
* Finish Adding Transfigured Gems (#22)
* Added gems from lines 564-623
* Finish adding transfigured gems
* Remove StormBrandAltY since it doesn't exist
* all transfigured gems exported
* enhancements
* added new Carrion Golem skills
* gave new Carrion Golem skills names
* add minion spells
* spelling fix
* cleanup level/stats iteration code for gems
* Update almost all dex gems
Gems without support are:
Blink / Mirror Arrow variants
Storm Rain
* Fix Static Strike Quality
Fixes#7031
* 3.23.0b export
* Add support for Ball Lightning of Static
* Update stat describer for invert_chance and divide_by_one_hundred_1dp
* Fix statDescriptionScope + Stats tables on some gem exports
The statDescriptionScope was defaulting to `skill_stat_descriptions` instead of copying the scope from the base gem variant
The new Transfigured gems inherit the base damage scaling from the base gem and use negative values to adjust for the Transfigured version
* Fix indenting
* Remove old code supporting Divergent Ball Lightning
* Update almost all str skills
* Update Vaal Cleave Buff
* Fix spelling
---------
Co-authored-by: Mark Cunningham <86213229+markoleptic@users.noreply.github.com>
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Co-authored-by: Andreas Svanberg <andreas.svanberg@mensa.se>
Co-authored-by: Wires77 <Wires77@users.noreply.github.com>
* WIP skills export
* Export skills, fix dat file loading bug
* Add back IncrementalEffectiveness
* Don't export gems that don't have a manual GrantedEffect
* Manual fix for Frostbomb
* WIP skills export
* Export skills, fix dat file loading bug
* Add back IncrementalEffectiveness
* Don't export gems that don't have a manual GrantedEffect
* Manual fix for Frostbomb
* Fix Interpolation for DoTs
* Update all dex gems and remove old mods
Adds support for all the new stats on the base dex gems
Remove mods from gems that no longer exist on the base or Transfigured version of the gem
* 1/3rd of Int gems up to Frost Bomb
* Updating Strength skill gems for 3.23
Also removed a condition on Rage Vortex as now the quality can be pumped
up to arbitrarily high values
* Fix remaining intelligence gems
Fix remaining gems
Add support for tertiary durations for Wintertide Brand debuff
Re-organise gems into alphabetical order
* Fix up strength gems
* Update skills from items
* Fix spectres
* Dex Support gems
* Int Support gems
* Export str supports
* Remove redundant line
* Comment out Petrified Blood tests
Petrified Blood losing alt quality makes this test hard to understand.
Plan on revisiting this later to at least simply use the numbers in PoB
* Fix SRS
* New Ascendancy skills
* Adding support for Ravenous and Pacify
* Fix SRS
* Add support for Barkskin
* Move skills
---------
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
--- Implemented Enhancements ---
* Support for triggered skills has been reworked.
* Calculations of effective triggered skills trigger rate should now be more accurate.
* Improve cooldown breakpoint interactions with skills that add cast time.
* Implemented all currently existing trigger skills that POB is capable of supporting. Including:
* CWDT
* Spell Slinger
* Counter attack skills
* Arcanist brand
* Tawhoa's Chosen
* Battlemage's Cry
* Implemented Trigger Bots.
--- User Interface ---
* Trigger related breakdowns should now be more descriptive.
* Improve breakdowns for skills that add cast time.
* Display Cast When damage taken threshold in the trigger rate section
--- Fixed Bugs ---
* Triggers should now correctly account for source rate modifiers such as crit chance and accuracy.
* Fixed inaccuracies caused by incorrect handling of skill cooldown during skill rotation simulation.
* Fixed a crash caused by an interaction between unleash and nested triggers.
* Fixed many self triggers counting as self cast.
* Fixed incorrect handling of gems supported by more than one trigger.
* FEAT: impl more sources of self hit dmg
This code has been moved from #4599 after abandoning cwdt loop support.
* FIX: spelling
* FIX: remove file implemented in #4599
* Add support for non-Boneshatter Trauma
* Add new gems from 3.22 and other stuff
* Fix Crucible Export
* Fix Ruthless support to work with all ailments
* Update for actual support gem
* Support inc stun duration per trauma
* add devour, volatility and locus mine support (#6412)
* add devour, volatility and locus mine support
* Add full support for gems
Add mine tag to Locus Mine
Add support for Anomalous Devour
Fix Mine PvP damage multiplier
Fix flags for damage against full/low life enemies
---------
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
* Spellblade support (#6343)
* Initial spellblade support
* Update label for spellblade damage breakdown
* Update with actual stats and qualities
* Update .txt too
* Floor all final flat values
---------
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
* Fix export
* Add spacing and fix typos
Alter the breakdowns to no longer show the damage taken multi/taken % line if the value has not changed
Added spacing to the lines so you can more clearly read the breakdown when you have multiple taken as elements
Fix some spacing and spelling mistakes
---------
Co-authored-by: Paliak <91493239+Paliak@users.noreply.github.com>
Co-authored-by: Lilylicious <lily.hammerskog@gmail.com>
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Co-authored-by: Regisle <49933620+Regisle@users.noreply.github.com>
Co-authored-by: Lily <Lilylicious@users.noreply.github.com>
* added new DAT tables that we probably care about
* new skillType tag
* remove Onslaught gem from export
* fixed Gem Levels, renamed appropriately
* added all new skills/vaal and spec
* Existing Gem changes
* fixed helm enchantment for Snipe
* Spec change for crucible tags
* fixes to add Momentum and Quickstep
---------
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
* initial vaal skill Improvements
* change vaal stored use name and fix missing duration mod
* re export after merge
* Move Cooldown before soul stuff
* Added parsing for more mods
Hits from Socketed Vaal Skills ignore Enemy Monster Resistances
Hits from Socketed Vaal Skills ignore Enemy Monster Physical Damage Reduction
Socketed Vaal Skills grant Elusive when Used
You have Tailwind if you've used a Socketed Vaal Skill Recently
Damage with Hits from Socketed Vaal Skills is Lucky
---------
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
* Update pvp multipliers
* Export PvP values from GGPK
* Fix not working with support gems
* add pvp tvalue Multipliers for flameblast
---------
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
* Add stored uses
* lower case and add tooltip
* Make implementations generic.
* Add proper parsing
* typo
* Add breakdown and make extracooldown from second wind for non instant skills.
* Fix accidently missing readding warcry
* Fix forgetting to update .txt
* FIX: add area flag to Minion Instability.
* FIX: fix chaos aura skill tags.
Fixes missing tags on the Chaos Aura skill that chaos golem can use.
Also changes the skill type flags on minion instability to use the
standard enums.
* FIX: change minion.txt to fix exports
* FIX: add addSkillTypes Directive to skill exporter.
* FIX: add flags to stone golem slam attack
* FIX: improve naming consistency
* Fixes old skills with 3.20 export
* Grab new skills and Nostras changes
* Add Reminder Text file
* Add support for Vaal Caustic Arrow, Venom Gyre and Blade Flurry
Only partial support for vaal blade flurry
* Move Cursed Ground and Hex Bloom Support
* Add support for remaining new skills
Vaal Cleave still needs it's buff added
* Accident
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
* Fix various errors caused by Barrage / Barrage Support ambiguity
* Update level requirement fallback behavior
* FIX: don't strip support from the name of some gems as that causes name colissions
Co-authored-by: Lothrik <maximius@gmail.com>
Fix shield skills with offhand crit chance and attack time values
Fix crash for skills with empty costs
Move crit chance tooltip to below attack/cast rate
Fix Spectral Wolf
Remove Duration from level skill import and fix duration crash for warcries
* fix: use proper SkillType names
* fix: re-exported stats
* fix: re-exported misc data
* fix: re-exported skills with new SkillType tags
* fix: use of SkillType tags to new names in code
* fix: fix some inconsistencies in minion duration
* Fix Mirage Archer skill tag
* Update comment
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
* Dumped skils
* added new SkillTypes
* updated new types with names; added stat descriptions; added pantheon updates
* fix Rigwalds
* added more missing gems; fixed up Enchant matching
* fix to some skill labels on Seismic Trap
* fixed lua as well
* Update gem mods from manual update
Also add secondary support for Battlemage's Cry
* Adding single minion stat descriptions
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Co-authored-by: Wires77 <Wires77@users.noreply.github.com>
* wip
* changes to baseEffectiveness, incrementalEffectiveness export and use in interpolate when methods is '3'
* more work
* added working preDamageFunc()
* added multi-stage support
* Blood Sacrament fixes; Essence work parsing fix
* Fix export script and add radius
* added radius to Blood Sacrament
* fixed radius scaling
* added unique jewels, boots, gloves
* added all non-variant uniques
* fixed line-split on Temptation Step
* removed gloves from Hateforge
* added league tag, moved shield
* one more league tag
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
* start
* added atziri staff unique skills
* stat descriptions
* mods
* implemented 'divide_by_six'
* minions & spectres
* helmet enchantments (with typo fixed for Lancing Steel)
* more helmet enchants
* Essences
* added Gem data
* Atziri unique item skills added
* Setting mana cost and reservations
* Fix enchant exporting
* Fix Watchers eye mod
* Forgot to commit new function for shorts
* Updating a couple more data fields in the ggpk viewer
* Skills (missing quality)
* Update spec
* Update Spec
* Add initial support for new costs
* Fix reservation
* Regenerating skills
* Adding alternate qualities back in
* extracted all but bases
* Removing UIntOffset
* Add support for new gems
Revert legion keystone deletion
Add support for all new skill gems
* Manual file changes
Co-authored-by: Wires77 <Wires77@users.noreply.github.com>
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Co-authored-by: PJacek <PJacek@users.noreply.github.com>
