From ac25fb23f91ca31f0c11d168643425c7dd761462 Mon Sep 17 00:00:00 2001 From: LocalIdentity <31035929+LocalIdentity@users.noreply.github.com> Date: Fri, 1 Aug 2025 17:50:13 +1000 Subject: [PATCH] Fix Volatility applying to Minion Spell skills (#8912) * FIX(mirage): fix cap GC cooldown by mirage+attack delay The Howlcrack unique item sets the cooldown of warcies to 0 causing the GC dps to explode into infinity due to division by zero. This was caused by the assumption that the mirages instantly spawn and attack. This commit makes it so that the cooldown is at least the amount of time it takes to spawm them all and attack or channel for 1s. * FIX: cleanup handling of limitedSkills table * FIX: cleanup target skill selection for SacredWisps and MirageArcher * FIX: mark the cache generated by mirage calcs as CALCULATOR The env used by mirage skills is often modified causing the resulting env to differ. This has not caused issues to there not beign any caching use after calcMirages but this could come up in the future. Marking the env as CALCULATOR still allows for the env to be cached in case it's really needed but it will prevent it being used in most cases. * FIX: remove vestigial CACHE table This was once used as the main table holding the cached output of skills. It has been entirely replaced by the remaining tables. * MISC: typo * FIX: typo * Fix Volatility applying to Minion Spell skills Volatility was not being restricted to minion spells after we recently changed how we were applying support gems to minions --------- Co-authored-by: Paliak <91493239+Paliak@users.noreply.github.com> Co-authored-by: LocalIdentity --- src/Data/Skills/sup_str.lua | 4 ++-- src/Export/Skills/sup_str.txt | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Data/Skills/sup_str.lua b/src/Data/Skills/sup_str.lua index b8ed3db0..15033adc 100644 --- a/src/Data/Skills/sup_str.lua +++ b/src/Data/Skills/sup_str.lua @@ -4380,10 +4380,10 @@ skills["SupportVolatility"] = { statDescriptionScope = "gem_stat_descriptions", statMap = { ["minimum_attack_damage_+%_final_from_volatility_support"] = { - mod("MinDamage", "MORE", nil), + mod("MinDamage", "MORE", nil, 0, 0, { type = "SkillType", skillType = SkillType.Attack }), }, ["maximum_attack_damage_+%_final_from_volatility_support"] = { - mod("MaxDamage", "MORE", nil), + mod("MaxDamage", "MORE", nil, 0, 0, { type = "SkillType", skillType = SkillType.Attack }), }, }, qualityStats = { diff --git a/src/Export/Skills/sup_str.txt b/src/Export/Skills/sup_str.txt index 5ed470db..b8f1b04e 100644 --- a/src/Export/Skills/sup_str.txt +++ b/src/Export/Skills/sup_str.txt @@ -603,10 +603,10 @@ local skills, mod, flag, skill = ... #skill SupportVolatility statMap = { ["minimum_attack_damage_+%_final_from_volatility_support"] = { - mod("MinDamage", "MORE", nil), + mod("MinDamage", "MORE", nil, 0, 0, { type = "SkillType", skillType = SkillType.Attack }), }, ["maximum_attack_damage_+%_final_from_volatility_support"] = { - mod("MaxDamage", "MORE", nil), + mod("MaxDamage", "MORE", nil, 0, 0, { type = "SkillType", skillType = SkillType.Attack }), }, }, #mods