From 98d242f2943b54cb5eb0eaa04798795321c6c68d Mon Sep 17 00:00:00 2001 From: LocalIdentity <31035929+LocalIdentity@users.noreply.github.com> Date: Tue, 1 Jul 2025 16:03:43 +1000 Subject: [PATCH] Fix Runegraft bonus for Boots / Gloves scaling skill gems (#8764) * Fix Runegraft bonus for Boots / Gloves scaling skill levels The Runegraft mod only scales mods on items that come from stats, since socketed gem effects are properties of a GrantedEffect, they are not scaled by the bonus effect * Filter out ExtraSkillMod --------- Co-authored-by: LocalIdentity --- src/Modules/CalcSetup.lua | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/src/Modules/CalcSetup.lua b/src/Modules/CalcSetup.lua index 32658d01..23248814 100644 --- a/src/Modules/CalcSetup.lua +++ b/src/Modules/CalcSetup.lua @@ -1192,9 +1192,11 @@ function calcs.initEnv(build, mode, override, specEnv) if gloveEffectMod ~= 0 then local modList = env.player.itemList["Gloves"].modList for _, mod in ipairs(modList) do - local modCopy = copyTable(mod) - modCopy.source = "Many Sources:" .. tostring(gloveEffectMod * 100) .. "% Gloves Bonus Effect" - modDB:ScaleAddMod(modCopy, gloveEffectMod) + if not (mod.name == "ExtraSupport" or mod.name == "ExtraSkill" or mod.name == "ExtraSupport" or mod.name == "ExtraSkillMod" or (mod[1] and mod[1].type == "SocketedIn")) then + local modCopy = copyTable(mod) + modCopy.source = tostring(gloveEffectMod * 100) .. "% Gloves Bonus Effect" + modDB:ScaleAddMod(modCopy, gloveEffectMod) + end end end end @@ -1203,9 +1205,11 @@ function calcs.initEnv(build, mode, override, specEnv) if bootEffectMod ~= 0 then local modList = env.player.itemList["Boots"].modList for _, mod in ipairs(modList) do - local modCopy = copyTable(mod) - modCopy.source = "Many Sources:" .. tostring(bootEffectMod * 100) .. "% Boots Bonus Effect" - modDB:ScaleAddMod(modCopy, bootEffectMod) + if not (mod.name == "ExtraSupport" or mod.name == "ExtraSkill" or mod.name == "ExtraSupport" or mod.name == "ExtraSkillMod" or (mod[1] and mod[1].type == "SocketedIn")) then + local modCopy = copyTable(mod) + modCopy.source = tostring(bootEffectMod * 100) .. "% Boots Bonus Effect" + modDB:ScaleAddMod(modCopy, bootEffectMod) + end end end end