From 6c5abc3d6adcded3bc59979503371eb6e4b8b0bd Mon Sep 17 00:00:00 2001
From: ppoelzl <33464174+ppoelzl@users.noreply.github.com>
Date: Mon, 17 Aug 2020 23:04:21 +0200
Subject: [PATCH] Refactor out keystone list

---
 Modules/Data.lua          | 29 +++++++++++++++++++++++++++++
 Modules/ModParser-3_0.lua | 30 +-----------------------------
 2 files changed, 30 insertions(+), 29 deletions(-)

diff --git a/Modules/Data.lua b/Modules/Data.lua
index b80e80a8..32f5b4c7 100644
--- a/Modules/Data.lua
+++ b/Modules/Data.lua
@@ -209,6 +209,35 @@ data.specialBaseTags = {
 	["Sceptre"] = { shaper = "sceptre_shaper", elder = "sceptre_elder", adjudicator = "sceptre_adjudicator", basilisk = "sceptre_basilisk", crusader = "sceptre_crusader", eyrie = "sceptre_eyrie", },
 }
 
+---@type string[] @List of keystones that can be found on unique items.
+data.keystones = {
+	"Acrobatics",
+	"Ancestral Bond",
+	"Arrow Dancing",
+	"Avatar of Fire",
+	"Blood Magic",
+	"Call to Arms",
+	"Conduit",
+	"Crimson Dance",
+	"Eldritch Battery",
+	"Elemental Equilibrium",
+	"Elemental Overload",
+	"Ghost Reaver",
+	"Iron Grip",
+	"Iron Reflexes",
+	"Mind Over Matter",
+	"Minion Instability",
+	"Mortal Conviction",
+	"Pain Attunement",
+	"Perfect Agony",
+	"Phase Acrobatics",
+	"Point Blank",
+	"Resolute Technique",
+	"Unwavering Stance",
+	"Vaal Pact",
+	"Zealot's Oath",
+}
+
 data.misc = { -- magic numbers
 	ServerTickRate = 30,
 	TemporalChainsEffectCap = 75,
diff --git a/Modules/ModParser-3_0.lua b/Modules/ModParser-3_0.lua
index 914df269..a2af90b0 100644
--- a/Modules/ModParser-3_0.lua
+++ b/Modules/ModParser-3_0.lua
@@ -2382,35 +2382,7 @@ local specialModList = {
 	["you take (%d+)%% reduced extra damage from critical strikes"] = function(num) return { mod("ReduceCritExtraDamage", "BASE", num) } end,
 	["you take (%d+)%% reduced extra damage from critical strikes while you have no power charges"] = function(num) return { mod("ReduceCritExtraDamage", "BASE", num, { type = "StatThreshold", stat = "PowerCharges", threshold = 0, upper = true }) } end,
 }
-local keystoneList = {
-	-- List of keystones that can be found on uniques
-	"Acrobatics",
-	"Ancestral Bond",
-	"Arrow Dancing",
-	"Avatar of Fire",
-	"Blood Magic",
-	"Call to Arms",
-	"Conduit",
-	"Crimson Dance",
-	"Eldritch Battery",
-	"Elemental Equilibrium",
-	"Elemental Overload",
-	"Ghost Reaver",
-	"Iron Grip",
-	"Iron Reflexes",
-	"Mind Over Matter",
-	"Minion Instability",
-	"Mortal Conviction",
-	"Pain Attunement",
-	"Perfect Agony",
-	"Phase Acrobatics",
-	"Point Blank",
-	"Resolute Technique",
-	"Unwavering Stance",
-	"Vaal Pact",
-	"Zealot's Oath",
-}
-for _, name in pairs(keystoneList) do
+for _, name in pairs(data.keystones) do
 	specialModList[name:lower()] = { mod("Keystone", "LIST", name) }
 end
 local oldList = specialModList